From: koro.chen@mediatek.com (Koro Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: mediatek: add i2c dependency
Date: Thu, 14 Jan 2016 09:43:15 +0800 [thread overview]
Message-ID: <1452735795.28205.1.camel@mtksdaap41> (raw)
In-Reply-To: <5346380.rqT2CVl4PH@wuerfel>
On Wed, 2016-01-13 at 23:14 +0100, Arnd Bergmann wrote:
> The newly added mediatek drivers for mt8173 select codes that depend
> on I2C, which cuases a build failure if I2C is disabled:
>
> warning: (SND_SOC_ADAU1761_I2C && SND_SOC_ADAU1781_I2C && SND_SOC_ADAU1977_I2C && SND_SOC_RT5677 && EXTCON_MAX14577 && EXTCON_MAX77693 && EXTCON_MAX77843 && BMC150_ACCEL_I2C && BMG160_I2C) selects REGMAP_I2C which has unmet direct dependencies (I2C)
> codecs/rt5645.c:3854:1: warning: data definition has no type or storage class
> codecs/rt5645.c:3854:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> codecs/rt5677.c:5270:1: warning: data definition has no type or storage class
> 77_i2c_driver);
>
> codecs/rt5677.c:5270:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
>
> This adds an explicit dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index 15c04e2eae34..976967675387 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -9,7 +9,7 @@ config SND_SOC_MEDIATEK
>
> config SND_SOC_MT8173_MAX98090
> tristate "ASoC Audio driver for MT8173 with MAX98090 codec"
> - depends on SND_SOC_MEDIATEK
> + depends on SND_SOC_MEDIATEK && I2C
> select SND_SOC_MAX98090
> help
> This adds ASoC driver for Mediatek MT8173 boards
> @@ -19,7 +19,7 @@ config SND_SOC_MT8173_MAX98090
>
> config SND_SOC_MT8173_RT5650_RT5676
> tristate "ASoC Audio driver for MT8173 with RT5650 RT5676 codecs"
> - depends on SND_SOC_MEDIATEK
> + depends on SND_SOC_MEDIATEK && I2C
> select SND_SOC_RT5645
> select SND_SOC_RT5677
> help
>
Acked-by: Koro Chen <koro.chen@mediatek.com>
Thank you!
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2016-01-14 1:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 22:14 [PATCH] ASoC: mediatek: add i2c dependency Arnd Bergmann
2016-01-14 1:43 ` Koro Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452735795.28205.1.camel@mtksdaap41 \
--to=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox