From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init()
Date: Mon, 18 Jan 2016 10:43:26 +0100 [thread overview]
Message-ID: <1453110206.3183.0.camel@pengutronix.de> (raw)
In-Reply-To: <569BD501.6040308@tribudubois.net>
Am Sonntag, den 17.01.2016, 18:53 +0100 schrieb Jean-Christophe DUBOIS:
> Shawn, Sascha,
>
> Are you OK with this patch?
>
> JC
>
Looks good.
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> Le 26/12/2015 23:16, Jean-Christophe Dubois a ?crit :
> > The wrong pointer is passed to the ioumap function in the cleanup path
> >
> > Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
> > ---
> > arch/arm/mach-imx/pm-imx6.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> > index 4470376..58924b3 100644
> > --- a/arch/arm/mach-imx/pm-imx6.c
> > +++ b/arch/arm/mach-imx/pm-imx6.c
> > @@ -561,13 +561,13 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata)
> > goto put_node;
> >
> > pl310_cache_map_failed:
> > - iounmap(&pm_info->gpc_base.vbase);
> > + iounmap(pm_info->gpc_base.vbase);
> > gpc_map_failed:
> > - iounmap(&pm_info->iomuxc_base.vbase);
> > + iounmap(pm_info->iomuxc_base.vbase);
> > iomuxc_map_failed:
> > - iounmap(&pm_info->src_base.vbase);
> > + iounmap(pm_info->src_base.vbase);
> > src_map_failed:
> > - iounmap(&pm_info->mmdc_base.vbase);
> > + iounmap(pm_info->mmdc_base.vbase);
> > put_node:
> > of_node_put(node);
> >
>
>
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-01-18 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 22:16 [PATCH] [ARM] i.MX6: fix cleanup path in imx6q_suspend_init() Jean-Christophe Dubois
2016-01-17 17:53 ` Jean-Christophe DUBOIS
2016-01-18 9:43 ` Lucas Stach [this message]
2016-01-28 6:36 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453110206.3183.0.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).