From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: Allow clocks to be marked as CRITICAL
Date: Mon, 18 Jan 2016 14:28:49 +0000 [thread overview]
Message-ID: <1453127331-20616-2-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1453127331-20616-1-git-send-email-lee.jones@linaro.org>
Critical clocks are those which must not be gated, else undefined
or catastrophic failure would occur. Here we have chosen to
ensure the prepare/enable counts are correctly incremented, so as
not to confuse users with enabled clocks with no visible users.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/clk/clk.c | 7 ++++++-
include/linux/clk-provider.h | 1 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index f13c3f4..835cb85 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2576,8 +2576,13 @@ struct clk *clk_register(struct device *dev, struct clk_hw *hw)
}
ret = __clk_init(dev, hw->clk);
- if (!ret)
+ if (!ret) {
+ if (core->flags & CLK_IS_CRITICAL) {
+ clk_core_prepare(core);
+ clk_core_enable(core);
+ }
return hw->clk;
+ }
__clk_free_clk(hw->clk);
hw->clk = NULL;
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index c56988a..ffa0b2e 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -31,6 +31,7 @@
#define CLK_SET_RATE_NO_REPARENT BIT(7) /* don't re-parent on rate change */
#define CLK_GET_ACCURACY_NOCACHE BIT(8) /* do not use the cached clk accuracy */
#define CLK_RECALC_NEW_RATES BIT(9) /* recalc rates after notifications */
+#define CLK_IS_CRITICAL BIT(10) /* do not gate, ever */
struct clk;
struct clk_hw;
--
1.9.1
next prev parent reply other threads:[~2016-01-18 14:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 14:28 [PATCH 0/3] clk: Add support for critical clocks Lee Jones
2016-01-18 14:28 ` Lee Jones [this message]
2016-01-18 17:15 ` [PATCH 1/3] clk: Allow clocks to be marked as CRITICAL Geert Uytterhoeven
2016-01-19 7:53 ` Lee Jones
2016-02-11 0:41 ` Michael Turquette
2016-01-18 14:28 ` [PATCH 2/3] clk: WARN_ON about to disable a critical clock Lee Jones
2016-02-11 0:43 ` Michael Turquette
2017-06-27 11:16 ` Dirk Behme
2017-07-03 11:53 ` Lee Jones
2017-07-03 12:01 ` Dirk Behme
2017-07-03 14:25 ` Lee Jones
2017-07-03 15:24 ` Dirk Behme
2017-07-03 16:06 ` Lee Jones
2016-01-18 14:28 ` [PATCH 3/3] clk: Provide OF helper to mark clocks as CRITICAL Lee Jones
2016-01-27 23:51 ` André Przywara
2016-02-01 6:32 ` Maxime Ripard
2016-02-01 8:22 ` Lee Jones
2016-02-11 0:38 ` Michael Turquette
2016-02-02 13:39 ` Andre Przywara
2016-02-02 15:02 ` Lee Jones
2016-02-11 0:48 ` Michael Turquette
2016-02-11 1:00 ` [PATCH 0/3] clk: Add support for critical clocks Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453127331-20616-2-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).