* [PATCH] ARM: realview: fix device tree build
@ 2016-01-21 12:04 Linus Walleij
2016-01-21 12:16 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2016-01-21 12:04 UTC (permalink / raw)
To: linux-arm-kernel
As it happens, two obj-$(CONFIG_FOO) += foo.o variables are
above obj-y := core.o, which doesn't work: the += directives
need to add something to the build and doesn't work if obj-y
is not set first, so move the obj-y to be on top and everything
builds nicely again.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC guys, please apply this directly for fixes.
---
arch/arm/mach-realview/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-realview/Makefile b/arch/arm/mach-realview/Makefile
index 8be6632407d8..dae8d86ef4cc 100644
--- a/arch/arm/mach-realview/Makefile
+++ b/arch/arm/mach-realview/Makefile
@@ -4,10 +4,9 @@
ccflags-$(CONFIG_ARCH_MULTIPLATFORM) := -I$(srctree)/$(src)/include \
-I$(srctree)/arch/arm/plat-versatile/include
-
+obj-y := core.o
obj-$(CONFIG_REALVIEW_DT) += realview-dt.o
obj-$(CONFIG_SMP) += platsmp-dt.o
-obj-y := core.o
ifdef CONFIG_ATAGS
obj-$(CONFIG_MACH_REALVIEW_EB) += realview_eb.o
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: realview: fix device tree build
2016-01-21 12:04 [PATCH] ARM: realview: fix device tree build Linus Walleij
@ 2016-01-21 12:16 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-01-21 12:16 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 21 January 2016 13:04:47 Linus Walleij wrote:
> As it happens, two obj-$(CONFIG_FOO) += foo.o variables are
> above obj-y := core.o, which doesn't work: the += directives
> need to add something to the build and doesn't work if obj-y
> is not set first, so move the obj-y to be on top and everything
> builds nicely again.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC guys, please apply this directly for fixes.
> ---
Applied, thanks!
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-21 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 12:04 [PATCH] ARM: realview: fix device tree build Linus Walleij
2016-01-21 12:16 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).