linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: aaro.koskinen@iki.fi (Aaro Koskinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: simple-card: don't fail if sysclk setting is not supported
Date: Sun, 24 Jan 2016 00:36:40 +0200	[thread overview]
Message-ID: <1453588600-14831-3-git-send-email-aaro.koskinen@iki.fi> (raw)
In-Reply-To: <1453588600-14831-1-git-send-email-aaro.koskinen@iki.fi>

Commit e22579713ae1 ("ASoC: simple card: set cpu-dai sysclk
with mclk-fs") added sysclk / SND_SOC_CLOCK_OUT setting, that makes
asoc_simple_card_hw_params fail if the operation is not supported,
although the intention clearly was to ignore ENOTSUPP. Fix it.

The patch fixes audio playback on Kirkwood / OpenRD client,
where the following errors are seen:

	asoc-simple-card sound: ASoC: machine hw_params failed: -524
	alsa-lib: /alsa-lib-1.0.28/src/pcm/pcm_hw.c:327:(snd_pcm_hw_hw_params) SNDRV_PCM_IOCTL_HW_PARAMS failed (-524): Unknown error 524

Fixes: e22579713ae1 ("ASoC: simple card: set cpu-dai sysclk with mclk-fs")
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
 sound/soc/generic/simple-card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 54c3320..ff6fcd9 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -100,7 +100,7 @@ static int asoc_simple_card_hw_params(struct snd_pcm_substream *substream,
 		if (ret && ret != -ENOTSUPP)
 			goto err;
 	}
-
+	return 0;
 err:
 	return ret;
 }
-- 
2.4.0

  parent reply	other threads:[~2016-01-23 22:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23 22:36 [PATCH 0/2] ARM/sound: fix audio on kirkwood-openrd-client Aaro Koskinen
2016-01-23 22:36 ` [PATCH 1/2] ARM: DTS: kirkwood-openrd-client: fix audio Aaro Koskinen
2016-01-24 17:37   ` Andrew Lunn
2016-01-24 20:56     ` Rick Thomas
2016-01-24 21:40       ` Martin Michlmayr
2016-01-25  3:26         ` Rick Thomas
2016-01-25 18:24           ` Aaro Koskinen
2016-01-26  1:55             ` Rick Thomas
2016-01-26  3:50             ` Rick Thomas
2016-01-26  8:58   ` Gregory CLEMENT
2016-01-23 22:36 ` Aaro Koskinen [this message]
2016-01-24 17:39   ` [PATCH 2/2] ASoC: simple-card: don't fail if sysclk setting is not supported Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453588600-14831-3-git-send-email-aaro.koskinen@iki.fi \
    --to=aaro.koskinen@iki.fi \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).