[PATCH] ARM: don't print missing L2 cache as error

[PATCH] ARM: don't print missing L2 cache as error

[Stefan Agner]

Not having a L2 cache controller is a shame, but not an error. Avoid
printing an error message if L2 controller initialization returns
with ENODEV.

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Hi Russel,

We use a multiplatform kernel for two similar SoC's, one with L2
cache the other without. Maybe silently ignore -ENODEV would be
an option too, not sure what is preferred here.

--
Stefan

 arch/arm/kernel/irq.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
index 1d45320e..f80c480 100644
--- a/arch/arm/kernel/irq.c
+++ b/arch/arm/kernel/irq.c
@@ -95,7 +95,9 @@ void __init init_IRQ(void)
 			outer_cache.write_sec = machine_desc->l2c_write_sec;
 		ret = l2x0_of_init(machine_desc->l2c_aux_val,
 				   machine_desc->l2c_aux_mask);
-		if (ret)
+		if (ret == -ENODEV)
+			pr_info("L2C: no device found\n");
+		else if (ret)
 			pr_err("L2C: failed to init: %d\n", ret);
 	}
 
-- 
2.7.0

[PATCH] ARM: don't print missing L2 cache as error

[Stefan Agner]

Hi Russel,

Any comment to this? Currently the kernel prints an error message as
follows on the platform at hand:
[    0.000000] L2C: failed to init: -19

--
Stefan


On 2016-01-27 17:27, Stefan Agner wrote:
> Not having a L2 cache controller is a shame, but not an error. Avoid
> printing an error message if L2 controller initialization returns
> with ENODEV.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Russel,
> 
> We use a multiplatform kernel for two similar SoC's, one with L2
> cache the other without. Maybe silently ignore -ENODEV would be
> an option too, not sure what is preferred here.
> 
> --
> Stefan
> 
>  arch/arm/kernel/irq.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
> index 1d45320e..f80c480 100644
> --- a/arch/arm/kernel/irq.c
> +++ b/arch/arm/kernel/irq.c
> @@ -95,7 +95,9 @@ void __init init_IRQ(void)
>  			outer_cache.write_sec = machine_desc->l2c_write_sec;
>  		ret = l2x0_of_init(machine_desc->l2c_aux_val,
>  				   machine_desc->l2c_aux_mask);
> -		if (ret)
> +		if (ret == -ENODEV)
> +			pr_info("L2C: no device found\n");
> +		else if (ret)
>  			pr_err("L2C: failed to init: %d\n", ret);
>  	}

[PATCH] ARM: don't print missing L2 cache as error

[Russell King - ARM Linux]

On Mon, Feb 15, 2016 at 07:19:20PM -0800, Stefan Agner wrote:
> Hi Russel,
> 
> Any comment to this? Currently the kernel prints an error message as
> follows on the platform at hand:
> [    0.000000] L2C: failed to init: -19

An alternative patch (8499/1) is queued for the next merge window, as it
isn't a regression and isn't a bug per se.

Thanks.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.