From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] kallsyms: remove --page-offset command line option
Date: Wed, 3 Feb 2016 20:04:56 +0100 [thread overview]
Message-ID: <1454526297-5269-4-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1454526297-5269-1-git-send-email-ard.biesheuvel@linaro.org>
The --page-offset command line option was only used for ARM, to filter
symbol addresses below CONFIG_PAGE_OFFSET. This is no longer needed, so
remove the functionality altogether.
Acked-by: Nicolas Pitre <nico@linaro.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
scripts/kallsyms.c | 27 ++++----------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 02473b71643b..ce36fc02fe8c 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -63,7 +63,6 @@ static unsigned int table_size, table_cnt;
static int all_symbols = 0;
static int absolute_percpu = 0;
static char symbol_prefix_char = '\0';
-static unsigned long long kernel_start_addr = 0;
static int base_relative = 0;
int token_profit[0x10000];
@@ -229,9 +228,6 @@ static int symbol_valid(struct sym_entry *s)
char *sym_name = (char *)s->sym + 1;
- if (s->addr < kernel_start_addr)
- return 0;
-
/* skip prefix char */
if (symbol_prefix_char && *sym_name == symbol_prefix_char)
sym_name++;
@@ -742,21 +738,11 @@ static void record_relative_base(void)
{
unsigned int i;
- if (kernel_start_addr > 0) {
- /*
- * If the kernel start address was specified, use that as
- * the relative base rather than going through the table,
- * since it should be a reasonable default, and values below
- * it will be ignored anyway.
- */
- relative_base = kernel_start_addr;
- } else {
- relative_base = -1ULL;
- for (i = 0; i < table_cnt; i++)
- if (!symbol_absolute(&table[i]) &&
- table[i].addr < relative_base)
- relative_base = table[i].addr;
- }
+ relative_base = -1ULL;
+ for (i = 0; i < table_cnt; i++)
+ if (!symbol_absolute(&table[i]) &&
+ table[i].addr < relative_base)
+ relative_base = table[i].addr;
}
int main(int argc, char **argv)
@@ -774,9 +760,6 @@ int main(int argc, char **argv)
if ((*p == '"' && *(p+2) == '"') || (*p == '\'' && *(p+2) == '\''))
p++;
symbol_prefix_char = *p;
- } else if (strncmp(argv[i], "--page-offset=", 14) == 0) {
- const char *p = &argv[i][14];
- kernel_start_addr = strtoull(p, NULL, 16);
} else if (strcmp(argv[i], "--base-relative") == 0)
base_relative = 1;
else
--
2.5.0
next prev parent reply other threads:[~2016-02-03 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 19:04 [PATCH v2 0/4] kallsyms: remove special handling for CONFIG_ARM Ard Biesheuvel
2016-02-03 19:04 ` [PATCH v2 1/4] ARM: move .vectors and .stubs sections back into the kernel VMA Ard Biesheuvel
2016-02-03 19:04 ` [PATCH v2 2/4] kallsyms: remove special lower address limit for CONFIG_ARM Ard Biesheuvel
2016-02-03 19:04 ` Ard Biesheuvel [this message]
2016-02-03 19:04 ` [PATCH v2 4/4] ARM: use single definition for vectors-to-stubs section offset Ard Biesheuvel
2016-02-03 20:00 ` [PATCH v2 0/4] kallsyms: remove special handling for CONFIG_ARM Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454526297-5269-4-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).