Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: rrichter@caviumnetworks.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/6] of/fdt: make generic early_init_dt_add_memory_arch() a weak alias
Date: Tue, 9 Feb 2016 14:53:41 +0100	[thread overview]
Message-ID: <1455026026-11571-2-git-send-email-rrichter@caviumnetworks.com> (raw)
In-Reply-To: <1455026026-11571-1-git-send-email-rrichter@caviumnetworks.com>

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>

The function early_init_dt_add_memory_arch() is defined as __weak
so that archs can override it. However, in this override implementation,
it may still be useful to invoke the generic implementation, so instead,
rename the generic version to early_init_dt_add_memory() and turn the
original definition into a weak alias. This way, the generic version can
still be called even in the presence of an arch specific override.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Message-Id: <1442881288-13962-2-git-send-email-ard.biesheuvel@linaro.org>
Signed-off-by: Robert Richter <rrichter@cavium.com>
---
 drivers/of/fdt.c       | 7 +++++--
 include/linux/of_fdt.h | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 655f79db7899..cba8281ab5fd 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -980,7 +980,7 @@ int __init early_init_dt_scan_chosen(unsigned long node, const char *uname,
 #define MAX_MEMBLOCK_ADDR	((phys_addr_t)~0)
 #endif
 
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
 {
 	const u64 phys_offset = __pa(PAGE_OFFSET);
 
@@ -1038,7 +1038,7 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
 	return __va(memblock_alloc(size, align));
 }
 #else
-void __init __weak early_init_dt_add_memory_arch(u64 base, u64 size)
+void __init early_init_dt_add_memory(u64 base, u64 size)
 {
 	WARN_ON(1);
 }
@@ -1058,6 +1058,9 @@ void * __init __weak early_init_dt_alloc_memory_arch(u64 size, u64 align)
 }
 #endif
 
+__weak __alias(early_init_dt_add_memory)
+void early_init_dt_add_memory_arch(u64 base, u64 size);
+
 bool __init early_init_dt_verify(void *params)
 {
 	if (!params)
diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
index df9ef3801812..463a06ba87ac 100644
--- a/include/linux/of_fdt.h
+++ b/include/linux/of_fdt.h
@@ -65,6 +65,7 @@ extern int early_init_dt_scan_memory(unsigned long node, const char *uname,
 				     int depth, void *data);
 extern void early_init_fdt_scan_reserved_mem(void);
 extern void early_init_fdt_reserve_self(void);
+extern void early_init_dt_add_memory(u64 base, u64 size);
 extern void early_init_dt_add_memory_arch(u64 base, u64 size);
 extern int early_init_dt_reserve_memory_arch(phys_addr_t base, phys_addr_t size,
 					     bool no_map);
-- 
2.7.0.rc3

  reply	other threads:[~2016-02-09 13:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 13:53 [PATCH v4 0/6] arm64 UEFI early FDT handling Robert Richter
2016-02-09 13:53 ` Robert Richter [this message]
2016-02-09 13:53 ` [PATCH v4 2/6] arm64: override generic version of early_init_dt_add_memory_arch() Robert Richter
2016-02-09 13:53 ` [PATCH v4 3/6] efi: move FDT handling to separate object file Robert Richter
2016-02-09 13:53 ` [PATCH v4 4/6] arm64/efi: move EFI /chosen node parsing before early FDT processing Robert Richter
2016-02-09 13:53 ` [PATCH v4 5/6] arm64/efi: ignore DT memory nodes instead of removing them Robert Richter
2016-02-09 13:53 ` [PATCH v4 6/6] arm64/efi: ignore DT memreserve entries " Robert Richter
2016-02-09 14:35 ` [PATCH v4 0/6] arm64 UEFI early FDT handling Ard Biesheuvel
2016-02-11 11:42   ` Robert Richter
2016-02-11 12:14     ` Ard Biesheuvel
2016-02-11 13:03       ` Ganapatrao Kulkarni
2016-02-11 14:26         ` Ganapatrao Kulkarni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455026026-11571-2-git-send-email-rrichter@caviumnetworks.com \
    --to=rrichter@caviumnetworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox