* [PATCH] arm/arm64/crypto: assure that ECB modes don't require an IV
@ 2016-02-12 15:47 Jeremy Linton
2016-02-12 17:00 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Jeremy Linton @ 2016-02-12 15:47 UTC (permalink / raw)
To: linux-arm-kernel
ECB modes don't use an initialization vector. The kernel
/proc/crypto interface doesn't reflect this properly.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
arch/arm/crypto/aes-ce-glue.c | 4 ++--
arch/arm64/crypto/aes-glue.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/crypto/aes-ce-glue.c b/arch/arm/crypto/aes-ce-glue.c
index b445a5d..89a3a3e 100644
--- a/arch/arm/crypto/aes-ce-glue.c
+++ b/arch/arm/crypto/aes-ce-glue.c
@@ -364,7 +364,7 @@ static struct crypto_alg aes_algs[] = { {
.cra_blkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .ivsize = AES_BLOCK_SIZE,
+ .ivsize = 0,
.setkey = ce_aes_setkey,
.encrypt = ecb_encrypt,
.decrypt = ecb_decrypt,
@@ -441,7 +441,7 @@ static struct crypto_alg aes_algs[] = { {
.cra_ablkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .ivsize = AES_BLOCK_SIZE,
+ .ivsize = 0,
.setkey = ablk_set_key,
.encrypt = ablk_encrypt,
.decrypt = ablk_decrypt,
diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
index 05d9e16..7a3d22a 100644
--- a/arch/arm64/crypto/aes-glue.c
+++ b/arch/arm64/crypto/aes-glue.c
@@ -294,7 +294,7 @@ static struct crypto_alg aes_algs[] = { {
.cra_blkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .ivsize = AES_BLOCK_SIZE,
+ .ivsize = 0,
.setkey = aes_setkey,
.encrypt = ecb_encrypt,
.decrypt = ecb_decrypt,
@@ -371,7 +371,7 @@ static struct crypto_alg aes_algs[] = { {
.cra_ablkcipher = {
.min_keysize = AES_MIN_KEY_SIZE,
.max_keysize = AES_MAX_KEY_SIZE,
- .ivsize = AES_BLOCK_SIZE,
+ .ivsize = 0,
.setkey = ablk_set_key,
.encrypt = ablk_encrypt,
.decrypt = ablk_decrypt,
--
2.4.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] arm/arm64/crypto: assure that ECB modes don't require an IV
2016-02-12 15:47 [PATCH] arm/arm64/crypto: assure that ECB modes don't require an IV Jeremy Linton
@ 2016-02-12 17:00 ` Ard Biesheuvel
2016-02-15 15:51 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2016-02-12 17:00 UTC (permalink / raw)
To: linux-arm-kernel
On 12 February 2016 at 16:47, Jeremy Linton <jeremy.linton@arm.com> wrote:
> ECB modes don't use an initialization vector. The kernel
> /proc/crypto interface doesn't reflect this properly.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Thanks for spotting that!
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm/crypto/aes-ce-glue.c | 4 ++--
> arch/arm64/crypto/aes-glue.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/crypto/aes-ce-glue.c b/arch/arm/crypto/aes-ce-glue.c
> index b445a5d..89a3a3e 100644
> --- a/arch/arm/crypto/aes-ce-glue.c
> +++ b/arch/arm/crypto/aes-ce-glue.c
> @@ -364,7 +364,7 @@ static struct crypto_alg aes_algs[] = { {
> .cra_blkcipher = {
> .min_keysize = AES_MIN_KEY_SIZE,
> .max_keysize = AES_MAX_KEY_SIZE,
> - .ivsize = AES_BLOCK_SIZE,
> + .ivsize = 0,
> .setkey = ce_aes_setkey,
> .encrypt = ecb_encrypt,
> .decrypt = ecb_decrypt,
> @@ -441,7 +441,7 @@ static struct crypto_alg aes_algs[] = { {
> .cra_ablkcipher = {
> .min_keysize = AES_MIN_KEY_SIZE,
> .max_keysize = AES_MAX_KEY_SIZE,
> - .ivsize = AES_BLOCK_SIZE,
> + .ivsize = 0,
> .setkey = ablk_set_key,
> .encrypt = ablk_encrypt,
> .decrypt = ablk_decrypt,
> diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c
> index 05d9e16..7a3d22a 100644
> --- a/arch/arm64/crypto/aes-glue.c
> +++ b/arch/arm64/crypto/aes-glue.c
> @@ -294,7 +294,7 @@ static struct crypto_alg aes_algs[] = { {
> .cra_blkcipher = {
> .min_keysize = AES_MIN_KEY_SIZE,
> .max_keysize = AES_MAX_KEY_SIZE,
> - .ivsize = AES_BLOCK_SIZE,
> + .ivsize = 0,
> .setkey = aes_setkey,
> .encrypt = ecb_encrypt,
> .decrypt = ecb_decrypt,
> @@ -371,7 +371,7 @@ static struct crypto_alg aes_algs[] = { {
> .cra_ablkcipher = {
> .min_keysize = AES_MIN_KEY_SIZE,
> .max_keysize = AES_MAX_KEY_SIZE,
> - .ivsize = AES_BLOCK_SIZE,
> + .ivsize = 0,
> .setkey = ablk_set_key,
> .encrypt = ablk_encrypt,
> .decrypt = ablk_decrypt,
> --
> 2.4.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] arm/arm64/crypto: assure that ECB modes don't require an IV
2016-02-12 17:00 ` Ard Biesheuvel
@ 2016-02-15 15:51 ` Will Deacon
0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2016-02-15 15:51 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 12, 2016 at 06:00:01PM +0100, Ard Biesheuvel wrote:
> On 12 February 2016 at 16:47, Jeremy Linton <jeremy.linton@arm.com> wrote:
> > ECB modes don't use an initialization vector. The kernel
> > /proc/crypto interface doesn't reflect this properly.
> >
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
>
> Thanks for spotting that!
>
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks, I'll queue this for -rc5.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-15 15:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 15:47 [PATCH] arm/arm64/crypto: assure that ECB modes don't require an IV Jeremy Linton
2016-02-12 17:00 ` Ard Biesheuvel
2016-02-15 15:51 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).