From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/21] coresight: "DEVICE_ATTR_RO" should defined as static.
Date: Wed, 17 Feb 2016 17:51:43 -0700 [thread overview]
Message-ID: <1455756723-8456-2-git-send-email-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <1455756723-8456-1-git-send-email-mathieu.poirier@linaro.org>
From: Eric Long <eric.long@linaro.org>
"DEVICE_ATTR_RO(name)" should be defined as static. And
there is an unnecessary space at the front of the code.
The sparse tool output logs as the following:
coresight-etm4x.c:2224:1: warning: symbol 'dev_attr_trcoslsr' was
not declared. Should it be static?
coresight-etm4x.c:2225:1: warning: symbol 'dev_attr_trcpdcr' was
not declared. Should it be static?
coresight-etm4x.c:2226:1: warning: symbol 'dev_attr_trcpdsr' was
not declared. Should it be static?
And the smatch tool output logs as the following:
of_coresight.c:89 of_coresight_alloc_memory() warn:
inconsistent indenting
Signed-off-by: Eric Long <eric.long@linaro.org>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
drivers/hwtracing/coresight/of_coresight.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
index b6ae9cb6ff57..d6a92c6d3a66 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -2227,7 +2227,7 @@ static ssize_t name##_show(struct device *_dev, \
return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
readl_relaxed(drvdata->base + offset)); \
} \
-DEVICE_ATTR_RO(name)
+static DEVICE_ATTR_RO(name)
coresight_simple_func(trcoslsr, TRCOSLSR);
coresight_simple_func(trcpdcr, TRCPDCR);
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index b0973617826f..3cc57c1e3b5d 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev,
return -ENOMEM;
/* Children connected to this component via @outports */
- pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
+ pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
sizeof(*pdata->child_names),
GFP_KERNEL);
if (!pdata->child_names)
--
2.1.4
next prev parent reply other threads:[~2016-02-18 0:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 0:51 [PATCH 00/21] coresight: next v4.5-rc4 Mathieu Poirier
2016-02-18 0:51 ` Mathieu Poirier [this message]
2016-02-18 0:51 ` [PATCH 02/21] coresight: etm4x: Check every parameter used by dma_xx_coherent Mathieu Poirier
2016-02-18 0:51 ` [PATCH 03/21] coresight: associating path with session rather than tracer Mathieu Poirier
2016-02-18 0:51 ` [PATCH 04/21] coresight: add API to get sink from path Mathieu Poirier
2016-02-18 0:51 ` [PATCH 05/21] coresight: moving PM runtime operations to core framework Mathieu Poirier
2016-02-18 0:51 ` [PATCH 06/21] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier
2016-02-18 0:51 ` [PATCH 07/21] coresight: etm3x: moving sysFS entries to dedicated file Mathieu Poirier
2016-02-18 0:51 ` [PATCH 08/21] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier
2016-02-18 0:51 ` [PATCH 09/21] coresight: etm3x: splitting struct etm_drvdata Mathieu Poirier
2016-02-18 0:51 ` [PATCH 10/21] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier
2016-02-18 0:51 ` [PATCH 11/21] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier
2016-02-18 0:51 ` [PATCH 12/21] coresight: etm3x: changing default trace configuration Mathieu Poirier
2016-02-18 0:51 ` [PATCH 13/21] coresight: etm3x: consolidating initial config Mathieu Poirier
2016-02-18 0:51 ` [PATCH 14/21] coresight: etm3x: implementing user/kernel mode tracing Mathieu Poirier
2016-02-18 0:51 ` [PATCH 15/21] coresight: etm3x: implementing perf_enable/disable() API Mathieu Poirier
2016-02-18 0:51 ` [PATCH 16/21] coresight: etb10: moving to local atomic operations Mathieu Poirier
2016-02-18 0:51 ` [PATCH 17/21] coresight: etb10: adding operation mode for sink->enable() Mathieu Poirier
2016-02-18 0:52 ` [PATCH 18/21] coresight: etb10: implementing AUX API Mathieu Poirier
2016-02-18 0:52 ` [PATCH 19/21] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier
2016-02-18 0:52 ` [PATCH 20/21] coresight: introducing a global trace ID function Mathieu Poirier
2016-02-18 0:52 ` [PATCH 21/21] drivers/hwtracing: make coresight-* explicitly non-modular Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455756723-8456-2-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).