From: rrichter@caviumnetworks.com (Robert Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] net, thunderx: Use bool in structs where possible
Date: Thu, 18 Feb 2016 13:39:09 +0100 [thread overview]
Message-ID: <1455799149-19590-3-git-send-email-rrichter@caviumnetworks.com> (raw)
In-Reply-To: <1455799149-19590-1-git-send-email-rrichter@caviumnetworks.com>
From: Robert Richter <rrichter@cavium.com>
Looks like the :1 notation was accidentally introduced (this still
uses 1 byte per flag). Using bool instead, which is the common use.
Signed-off-by: Robert Richter <rrichter@cavium.com>
---
drivers/net/ethernet/cavium/thunder/nic.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/cavium/thunder/nic.h b/drivers/net/ethernet/cavium/thunder/nic.h
index 688828865c48..fa5b1d2d8e23 100644
--- a/drivers/net/ethernet/cavium/thunder/nic.h
+++ b/drivers/net/ethernet/cavium/thunder/nic.h
@@ -262,9 +262,9 @@ struct nicvf {
struct pci_dev *pdev;
u8 vf_id;
u8 node;
- u8 tns_mode:1;
- u8 sqs_mode:1;
- u8 loopback_supported:1;
+ bool tns_mode;
+ bool sqs_mode;
+ bool loopback_supported;
bool hw_tso;
u16 mtu;
struct queue_set *qs;
@@ -353,9 +353,9 @@ struct nic_cfg_msg {
u8 msg;
u8 vf_id;
u8 node_id;
- u8 tns_mode:1;
- u8 sqs_mode:1;
- u8 loopback_supported:1;
+ bool tns_mode;
+ bool sqs_mode;
+ bool loopback_supported;
u8 mac_addr[ETH_ALEN];
};
--
2.7.0.rc3
next prev parent reply other threads:[~2016-02-18 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 12:39 [PATCH 0/2] net: thunderx: Small cleanups Robert Richter
2016-02-18 12:39 ` [PATCH 1/2] net: thunderx: Fix const type in nicvf_set_rxfh() Robert Richter
2016-02-18 12:39 ` Robert Richter [this message]
2016-02-18 16:05 ` [PATCH 2/2] net, thunderx: Use bool in structs where possible David Miller
2016-02-18 16:42 ` Robert Richter
2016-02-18 20:06 ` David Miller
2016-02-22 11:00 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455799149-19590-3-git-send-email-rrichter@caviumnetworks.com \
--to=rrichter@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox