public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: yong.wu@mediatek.com (Yong Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver
Date: Mon, 22 Feb 2016 02:43:09 +0800	[thread overview]
Message-ID: <1456080189.25237.4.camel@mhfsdcap03> (raw)
In-Reply-To: <20160220070209.GA16577@roeck-us.net>

On Fri, 2016-02-19 at 23:02 -0800, Guenter Roeck wrote:
> On Wed, Feb 17, 2016 at 08:46:13AM +0800, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
[...]
> > +#include <linux/clk.h>
> > +#include <linux/component.h>
> > +#include <linux/dma-iommu.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/io.h>
> > +#include <linux/iommu.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/list.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_iommu.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/platform_device.h>
> > +#include <soc/mediatek/smi.h>
> > +#include <dt-bindings/memory/mt8173-larb-port.h>
> > +
> 
> Some missing includes:
> 
> linux/bug.h
> 	for WARN_ON()
> linux/device.h
> 	for dev_xxx() error messages, dev_get_drvdata(), etc.
> linux/err.h
> 	for error functions (IS_ERR, error definitions)
> linux/slab.h
> 	for kzalloc() etc.
> linux/spinlock.h
> 	for spinlock functions
> asm/barrier.h
> 	for wmb()
> 
> Guenter

Hi Guenter,
    Thanks for this suggestion. I'm sorry that I didn't get any build
warning or error here. Anyway I will add them and send a quick v10.

  reply	other threads:[~2016-02-21 18:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17  0:46 [PATCH v9 0/5] MT8173 IOMMU SUPPORT Yong Wu
2016-02-17  0:46 ` [PATCH v9 1/5] dt-bindings: iommu: Add binding for mediatek IOMMU Yong Wu
2016-02-17  0:46 ` [PATCH v9 2/5] dt-bindings: mediatek: Add smi dts binding Yong Wu
2016-02-17  0:46 ` [PATCH v9 3/5] memory: mediatek: Add SMI driver Yong Wu
2016-02-17  0:46 ` [PATCH v9 4/5] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu
2016-02-20  7:02   ` [v9,4/5] " Guenter Roeck
2016-02-21 18:43     ` Yong Wu [this message]
2016-02-17  0:46 ` [PATCH v9 5/5] dts: mt8173: Add iommu/smi nodes for mt8173 Yong Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456080189.25237.4.camel@mhfsdcap03 \
    --to=yong.wu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox