From: ynvich@gmail.com (Sergei Ianovich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] arm: pxa: fix DT node name for PXA27X usb
Date: Tue, 23 Feb 2016 15:01:41 +0300 [thread overview]
Message-ID: <1456228901.23036.9.camel@gmail.com> (raw)
In-Reply-To: <87oab8wyfe.fsf@belgarion.home>
Hi Robert,?
On Mon, 2016-02-22 at 16:35 +0100, Robert Jarzmik wrote:
> You're right, I haven't seen the pxa2xx.dtsi statement before.
>
> As such, could you amend a bit your patch please to :
> ?- add:
> Fixes: 0ec1939668e5 ("ARM: dts: pxa: add the usb host controller")
> ?- make the same change in pxa3xx.dtsi, as the same error is there
> ?- and more globally align pxa2xx.dtsi, pxa27x.dtsi and pxa3xx.dtsi
> ?- remove the compatible, reg, interrupts and status from both pxa27x.dtsi and
> ???pxa3xx.dtsi as they are redundant with the included pxa2xxx.dsti one
No problem. Let's figure out the best approach.
> I'm even wondering if the proper change wouldn't be to scrap the ohci
> declarations from pxa27x.dtsi and pxa3xx.dtsi, and only add the "clocks"
> property to pxa2xx.dtsi ...
Since clocks are declared in pxa27x.dtsi and?pxa3xx.dtsi, there is a
stronger ground to have node clocks properties set in pxa27x.dtsi
and?pxa3xx.dtsi as well. However, there is already nodes with clocks
properties in pxa2xx.dtsi.
I cannot choose, you should make a decision.
--
Sergei Ianovich <ynvich@gmail.com>
next prev parent reply other threads:[~2016-02-23 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 11:08 [PATCH v1] arm: pxa: fix DT node name for PXA27X usb Sergei Ianovich
2016-02-22 15:35 ` Robert Jarzmik
2016-02-23 12:01 ` Sergei Ianovich [this message]
2016-02-23 20:12 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456228901.23036.9.camel@gmail.com \
--to=ynvich@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).