From: plaes@plaes.org (Priit Laes)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: sunxi: spi: add notice about SPI FIFO limit.
Date: Fri, 26 Feb 2016 07:56:57 +0200 [thread overview]
Message-ID: <1456466217-6793-3-git-send-email-plaes@plaes.org> (raw)
In-Reply-To: <1456466217-6793-1-git-send-email-plaes@plaes.org>
From: Michal Suchanek <hramrach@gmail.com>
When testing SPI without DMA I noticed that filling the FIFO on the
spi controller causes timeout. This should never happen with DMA support
so just adding a comment.
Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
drivers/spi/spi-sun4i.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
index 78141a6..b750664 100644
--- a/drivers/spi/spi-sun4i.c
+++ b/drivers/spi/spi-sun4i.c
@@ -333,7 +333,9 @@ static int sun4i_spi_transfer_one(struct spi_master *master,
sun4i_spi_write(sspi, SUN4I_DMA_CTL_REG, 0);
/* Fill the TX FIFO */
- sun4i_spi_fill_fifo(sspi, SUN4I_FIFO_DEPTH);
+ /* Filling the fifo fully causes timeout for some reason - at least on spi2 on a10s */
+ /* The can_dma check is txlen >= SUN4I_FIFO_DEPTH so with DMA this should never happen anyway. */
+ sun4i_spi_fill_fifo(sspi, SUN4I_FIFO_DEPTH - 1);
}
/* Start the transfer */
--
2.7.2
next prev parent reply other threads:[~2016-02-26 5:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 5:56 [PATCH RESEND 0/2] spi: sun4i: add DMA support Priit Laes
2016-02-26 5:56 ` [PATCH 1/2] " Priit Laes
2016-02-26 12:25 ` Mark Brown
2016-02-26 12:51 ` Michal Suchanek
2016-03-06 21:42 ` Maxime Ripard
2016-03-10 9:01 ` Michal Suchanek
2016-03-17 7:27 ` Maxime Ripard
2016-03-17 10:58 ` Michal Suchanek
2016-03-17 11:43 ` Mark Brown
2016-03-17 11:54 ` Michal Suchanek
2016-03-17 11:58 ` Mark Brown
2016-03-18 20:23 ` Maxime Ripard
2016-03-18 20:33 ` Mark Brown
2016-02-26 5:56 ` Priit Laes [this message]
2016-03-06 18:12 ` [PATCH 2/2] ARM: sunxi: spi: add notice about SPI FIFO limit Maxime Ripard
2016-02-26 12:15 ` [PATCH RESEND 0/2] spi: sun4i: add DMA support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456466217-6793-3-git-send-email-plaes@plaes.org \
--to=plaes@plaes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox