From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] Revert "mtd: pxa2xx-flash: switch from ioremap_cache to memremap"
Date: Fri, 26 Feb 2016 18:34:11 +0100 [thread overview]
Message-ID: <1456508053-15015-2-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1456508053-15015-1-git-send-email-ard.biesheuvel@linaro.org>
This reverts commit 06968a54790d9dd87a5bb68e8197b5094eff63c3, since NOR
with memory semantics in array mode and RAM are not necessarily the same
thing, and architectures may implement ioremap_cache() and memremap()
with different memory attributes.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/mtd/maps/pxa2xx-flash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index 7497090e9900..9adc4ef30891 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
info->map.name);
return -ENOMEM;
}
- info->map.cached = memremap(info->map.phys, info->map.size,
- MEMREMAP_WB);
+ info->map.cached =
+ ioremap_cache(info->map.phys, info->map.size);
if (!info->map.cached)
printk(KERN_WARNING "Failed to ioremap cached %s\n",
info->map.name);
@@ -111,7 +111,7 @@ static int pxa2xx_flash_remove(struct platform_device *dev)
map_destroy(info->mtd);
iounmap(info->map.virt);
if (info->map.cached)
- memunmap(info->map.cached);
+ iounmap(info->map.cached);
kfree(info);
return 0;
}
--
2.5.0
next prev parent reply other threads:[~2016-02-26 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 17:34 [PATCH v2 0/3] fix memremap on ARM Ard Biesheuvel
2016-02-26 17:34 ` Ard Biesheuvel [this message]
2016-02-26 17:34 ` [PATCH v2 2/3] memremap: add arch specific hook for MEMREMAP_WB mappings Ard Biesheuvel
2016-02-26 17:34 ` [PATCH v2 3/3] ARM: memremap: implement arch_memremap_wb() Ard Biesheuvel
2016-03-03 16:24 ` [PATCH v2 0/3] fix memremap on ARM Ard Biesheuvel
2016-03-03 17:13 ` Russell King - ARM Linux
2016-03-03 17:16 ` Ard Biesheuvel
2016-03-03 17:27 ` Dan Williams
2016-03-03 17:30 ` Ard Biesheuvel
2016-03-03 17:33 ` Dan Williams
2016-03-03 17:41 ` Ard Biesheuvel
2016-03-03 17:55 ` Dan Williams
2016-03-03 17:57 ` Ard Biesheuvel
2016-03-03 18:01 ` Dan Williams
2016-03-03 18:07 ` Ard Biesheuvel
2016-03-03 19:36 ` Russell King - ARM Linux
2016-03-03 19:42 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456508053-15015-2-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).