From: kernel@martin.sperl.org (kernel at martin.sperl.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] clk: bcm2835: enable clocks that have been enabled by firmware
Date: Mon, 29 Feb 2016 11:39:19 +0000 [thread overview]
Message-ID: <1456745963-2403-4-git-send-email-kernel@martin.sperl.org> (raw)
In-Reply-To: <1456745963-2403-1-git-send-email-kernel@martin.sperl.org>
From: Martin Sperl <kernel@martin.sperl.org>
If a clock that has been enabled by the firmware gets disabled
by a driver this may right now result in a crash of the system
as then also the corresponding PLL_dividers as well as PLLs
get disabled (if not used) - some of which are used by the
VideoCore GPU (which also runs the firmware)
This patch prepares/enables those clocks that have been
configured by the firmware.
Whenever the clock framework implements either
CLK_IS_CRITICAL or HAND_OFF this can get changed to use this
new mechanism.
For this to be completely successful (i.e not missing a clock
and subsequently a pll) it is recommended to add all the known
clocks of the soc so that this can get applied to all clocks.
Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
---
drivers/clk/bcm/clk-bcm2835.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 30d6486..1fbb55d 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -37,6 +37,7 @@
* generator).
*/
+#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/clkdev.h>
#include <linux/clk/bcm2835.h>
@@ -1478,6 +1479,7 @@ static struct clk *bcm2835_register_clock(struct bcm2835_cprman *cprman,
struct clk_init_data init;
const char *parents[1 << CM_SRC_BITS];
size_t i;
+ struct clk *clk;
/*
* Replace our "xosc" references with the oscillator's
@@ -1511,7 +1513,18 @@ static struct clk *bcm2835_register_clock(struct bcm2835_cprman *cprman,
clock->data = data;
clock->hw.init = &init;
- return devm_clk_register(cprman->dev, &clock->hw);
+ clk = devm_clk_register(cprman->dev, &clock->hw);
+ if (IS_ERR_OR_NULL(clk))
+ return clk;
+
+ /* enable/prepare if the clock is enabled by the firmware */
+ if (cprman_read(cprman, data->ctl_reg) & CM_ENABLE) {
+ dev_info(cprman->dev,
+ "found firmware enabled clock %pC\n", clk);
+ clk_prepare_enable(clk);
+ }
+
+ return clk;
}
static int bcm2835_clk_probe(struct platform_device *pdev)
--
1.7.10.4
next prev parent reply other threads:[~2016-02-29 11:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 11:39 [PATCH 0/6] clk: bcm2835: fixes clk-bcm2835 driver issues kernel at martin.sperl.org
2016-02-29 11:39 ` [PATCH 1/6] clk: bcm2835: pll_off should only set CM_PLL_ANARST kernel at martin.sperl.org
2016-02-29 20:03 ` Eric Anholt
2016-02-29 11:39 ` [PATCH 2/6] clk: bcm2835: add locking to pll*_on/off methods kernel at martin.sperl.org
2016-02-29 20:06 ` Eric Anholt
2016-02-29 11:39 ` kernel at martin.sperl.org [this message]
2016-02-29 20:09 ` [PATCH 3/6] clk: bcm2835: enable clocks that have been enabled by firmware Eric Anholt
2016-03-17 17:39 ` Eric Anholt
2016-03-17 18:13 ` Martin Sperl
2016-03-17 18:23 ` Eric Anholt
2016-04-26 7:48 ` Martin Sperl
2016-02-29 11:39 ` [PATCH 4/6] clk: bcm2835: divider value has to be 1 or more kernel at martin.sperl.org
2016-02-29 20:11 ` Eric Anholt
2016-02-29 11:39 ` [PATCH 5/6] clk: bcm2835: correctly enable fractional clock support kernel at martin.sperl.org
2016-02-29 20:33 ` Eric Anholt
2016-02-29 21:59 ` Martin Sperl
2016-02-29 23:44 ` Eric Anholt
2016-03-01 5:52 ` Martin Sperl
2016-02-29 11:39 ` [PATCH 6/6] clk: bcm2835: clean up coding style issues kernel at martin.sperl.org
2016-02-29 20:20 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456745963-2403-4-git-send-email-kernel@martin.sperl.org \
--to=kernel@martin.sperl.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).