* [PATCH] ARM: dts: imx53-qsb: Fix gpio button polarity
@ 2016-03-01 7:14 Sascha Hauer
2016-03-01 13:41 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Sascha Hauer @ 2016-03-01 7:14 UTC (permalink / raw)
To: linux-arm-kernel
The polarity of the gpio buttons is defined to '0' which is
active high. The buttons are active low though which has been verified by
testing it and by looking into the schematics. While at it use
defines rathers than numbers for the key codes.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/arm/boot/dts/imx53-qsb-common.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx53-qsb-common.dtsi b/arch/arm/boot/dts/imx53-qsb-common.dtsi
index 53fd75c..e340bcc 100644
--- a/arch/arm/boot/dts/imx53-qsb-common.dtsi
+++ b/arch/arm/boot/dts/imx53-qsb-common.dtsi
@@ -59,21 +59,21 @@
power {
label = "Power Button";
- gpios = <&gpio1 8 0>;
- linux,code = <116>; /* KEY_POWER */
+ gpios = <&gpio1 8 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_POWER>;
};
volume-up {
label = "Volume Up";
- gpios = <&gpio2 14 0>;
- linux,code = <115>; /* KEY_VOLUMEUP */
+ gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
gpio-key,wakeup;
};
volume-down {
label = "Volume Down";
- gpios = <&gpio2 15 0>;
- linux,code = <114>; /* KEY_VOLUMEDOWN */
+ gpios = <&gpio2 15 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEDOWN>;
gpio-key,wakeup;
};
};
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: dts: imx53-qsb: Fix gpio button polarity
2016-03-01 7:14 [PATCH] ARM: dts: imx53-qsb: Fix gpio button polarity Sascha Hauer
@ 2016-03-01 13:41 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2016-03-01 13:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 01, 2016 at 08:14:02AM +0100, Sascha Hauer wrote:
> The polarity of the gpio buttons is defined to '0' which is
> active high. The buttons are active low though which has been verified by
> testing it and by looking into the schematics. While at it use
> defines rathers than numbers for the key codes.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-01 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-01 7:14 [PATCH] ARM: dts: imx53-qsb: Fix gpio button polarity Sascha Hauer
2016-03-01 13:41 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).