From: romain.izard.pro@gmail.com (Romain Izard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start
Date: Thu, 3 Mar 2016 11:29:39 +0100 [thread overview]
Message-ID: <1457000979-15717-1-git-send-email-romain.izard.pro@gmail.com> (raw)
If the internal counter is not refreshed when the watchdog is started
for the first time, the watchdog will trigger very rapidly. For example,
opening /dev/watchdog without writing in it will immediately trigger a
reboot, instead of waiting for the delay to expire.
To avoid this problem, reload the timer on opening the watchdog device.
Command: "while sleep 5; do echo 1; done > /dev/watchdog"
Before: system reset
After: the watchdog runs correctly
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/watchdog/sama5d4_wdt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
index a49634cdc1cc..e162fe140ae1 100644
--- a/drivers/watchdog/sama5d4_wdt.c
+++ b/drivers/watchdog/sama5d4_wdt.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/reboot.h>
#include <linux/watchdog.h>
+#include <linux/delay.h>
#include "at91sam9_wdt.h"
@@ -58,6 +59,8 @@ static int sama5d4_wdt_start(struct watchdog_device *wdd)
reg = wdt_read(wdt, AT91_WDT_MR);
reg &= ~AT91_WDT_WDDIS;
wdt_write(wdt, AT91_WDT_MR, reg);
+ udelay(125); /* > 4 cycles at 32,768 Hz */
+ wdt_write(wdt, AT91_WDT_CR, AT91_WDT_KEY | AT91_WDT_WDRSTT);
return 0;
}
--
2.5.0
next reply other threads:[~2016-03-03 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 10:29 Romain Izard [this message]
2016-03-03 12:10 ` [PATCH v1] watchdog: sama5d4_wdt: Reset delay on start Guenter Roeck
2016-03-03 12:53 ` Romain Izard
2016-03-03 19:02 ` Guenter Roeck
2016-03-04 1:35 ` Yang, Wenyou
2016-03-04 5:23 ` Guenter Roeck
2016-03-04 9:06 ` Romain Izard
2016-03-04 13:09 ` Guenter Roeck
2016-03-04 13:26 ` Romain Izard
2016-03-04 13:56 ` Guenter Roeck
2016-03-04 14:59 ` Lothar Waßmann
2016-03-04 15:26 ` Romain Izard
2016-03-04 15:56 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457000979-15717-1-git-send-email-romain.izard.pro@gmail.com \
--to=romain.izard.pro@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).