* [PATCH] arm64: efi: add missing frame pointer assignment
@ 2016-03-03 16:31 Ard Biesheuvel
2016-03-04 18:12 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: Ard Biesheuvel @ 2016-03-03 16:31 UTC (permalink / raw)
To: linux-arm-kernel
The prologue of the EFI entry point pushes x29 and x30 onto the stack but
fails to create the stack frame correctly by omitting the assignment of x29
to the new value of the stack pointer. So fix that.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/arm64/kernel/efi-entry.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/efi-entry.S b/arch/arm64/kernel/efi-entry.S
index 936022f0655e..e88c064b845c 100644
--- a/arch/arm64/kernel/efi-entry.S
+++ b/arch/arm64/kernel/efi-entry.S
@@ -35,6 +35,7 @@ ENTRY(entry)
* for image_addr variable passed to efi_entry().
*/
stp x29, x30, [sp, #-32]!
+ mov x29, sp
/*
* Call efi_entry to do the real work.
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm64: efi: add missing frame pointer assignment
2016-03-03 16:31 [PATCH] arm64: efi: add missing frame pointer assignment Ard Biesheuvel
@ 2016-03-04 18:12 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2016-03-04 18:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 03, 2016 at 05:31:32PM +0100, Ard Biesheuvel wrote:
> The prologue of the EFI entry point pushes x29 and x30 onto the stack but
> fails to create the stack frame correctly by omitting the assignment of x29
> to the new value of the stack pointer. So fix that.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/kernel/efi-entry.S | 1 +
> 1 file changed, 1 insertion(+)
Applied. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-04 18:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 16:31 [PATCH] arm64: efi: add missing frame pointer assignment Ard Biesheuvel
2016-03-04 18:12 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).