linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kernel@martin.sperl.org (kernel at martin.sperl.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/11] dmaengine: bcm2835: move cyclic member from bcm2835_chan into bcm2835_desc
Date: Sat,  5 Mar 2016 10:52:17 +0000	[thread overview]
Message-ID: <1457175142-28665-7-git-send-email-kernel@martin.sperl.org> (raw)
In-Reply-To: <1457175142-28665-1-git-send-email-kernel@martin.sperl.org>

From: Martin Sperl <kernel@martin.sperl.org>

In preparation to consolidating code we move the cyclic member
into the bcm_2835_desc structure.

Signed-off-by: Martin Sperl <kernel@martin.sperl.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
 drivers/dma/bcm2835-dma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 2cdc256..23b01c5 100644
--- a/drivers/dma/bcm2835-dma.c
+++ b/drivers/dma/bcm2835-dma.c
@@ -73,7 +73,6 @@ struct bcm2835_chan {
 	struct list_head node;
 
 	struct dma_slave_config	cfg;
-	bool cyclic;
 	unsigned int dreq;
 
 	int ch;
@@ -95,6 +94,8 @@ struct bcm2835_desc {
 
 	unsigned int frames;
 	size_t size;
+
+	bool cyclic;
 };
 
 #define BCM2835_DMA_CS		0x00
@@ -403,8 +404,6 @@ static void bcm2835_dma_issue_pending(struct dma_chan *chan)
 	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
 	unsigned long flags;
 
-	c->cyclic = true; /* Nothing else is implemented */
-
 	spin_lock_irqsave(&c->vc.lock, flags);
 	if (vchan_issue_pending(&c->vc) && !c->desc)
 		bcm2835_dma_start_desc(c);
@@ -458,6 +457,7 @@ static struct dma_async_tx_descriptor *bcm2835_dma_prep_dma_cyclic(
 	d->c = c;
 	d->dir = direction;
 	d->frames = buf_len / period_len;
+	d->cyclic = true;
 
 	d->cb_list = kcalloc(d->frames, sizeof(*d->cb_list), GFP_KERNEL);
 	if (!d->cb_list) {
-- 
2.1.4

  parent reply	other threads:[~2016-03-05 10:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-05 10:52 [PATCH v3 00/11] dmaengine: bcm2835: bugfix + enhancement of driver kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 01/11] dmaengine: bcm2835: set residue_granularity field kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 02/11] dmaengine: bcm2835: remove unnecessary masking of dma channels kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 03/11] dmaengine: bcm2835: use shared interrupt for channel 11 to 14 kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties kernel at martin.sperl.org
2016-03-07 23:24   ` Eric Anholt
2016-03-08 11:23     ` Martin Sperl
2016-03-11  5:53       ` Vinod Koul
2016-03-10  8:57   ` Mark Rutland
2016-03-11  8:51     ` Martin Sperl
2016-03-22  9:23       ` Martin Sperl
2016-03-22 10:24         ` Mark Rutland
2016-03-05 10:52 ` [PATCH v3 05/11] dmaengine: bcm2835: add additional defines for DMA-registers kernel at martin.sperl.org
2016-03-05 10:52 ` kernel at martin.sperl.org [this message]
2016-03-05 10:52 ` [PATCH v3 07/11] dmaengine: bcm2835: move controlblock chain generation into separate method kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 08/11] dmaengine: bcm2835: limit max length based on channel type kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 09/11] dmaengine: bcm2835: add slave_sg support to bcm2835-dma kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 10/11] dmaengine: bcm2835: add dma_memcopy " kernel at martin.sperl.org
2016-03-05 10:52 ` [PATCH v3 11/11] dmaengine: bcm2835: expose dma registers via debugfs kernel at martin.sperl.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457175142-28665-7-git-send-email-kernel@martin.sperl.org \
    --to=kernel@martin.sperl.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).