From: jeremy.linton@arm.com (Jeremy Linton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] arm: pmu: Fix non-devicetree probing
Date: Sun, 13 Mar 2016 18:23:15 -0500 [thread overview]
Message-ID: <1457911398-22412-2-git-send-email-jeremy.linton@arm.com> (raw)
In-Reply-To: <1457911398-22412-1-git-send-email-jeremy.linton@arm.com>
From: Mark Salter <msalter@redhat.com>
There is a problem in the non-devicetree PMU probing where some
probe functions may get the number of supported events through
smp_call_function_any() using the arm_pmu supported_cpus mask.
But at the time the probe function is called, the supported_cpus
mask is empty so the call fails. This patch makes sure the mask
is set before calling the init function rather than after.
Signed-off-by: Mark Salter <msalter@redhat.com>
---
drivers/perf/arm_pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index 11bacc7..0f33c96 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -997,8 +997,8 @@ int arm_pmu_device_probe(struct platform_device *pdev,
if (!ret)
ret = init_fn(pmu);
} else {
- ret = probe_current_pmu(pmu, probe_table);
cpumask_setall(&pmu->supported_cpus);
+ ret = probe_current_pmu(pmu, probe_table);
}
if (ret) {
--
2.4.3
next prev parent reply other threads:[~2016-03-13 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 23:23 [RFC 0/4 v3] arm64/perf: Add ACPI support Jeremy Linton
2016-03-13 23:23 ` Jeremy Linton [this message]
2016-03-13 23:23 ` [PATCH 2/4] arm64: pmu: add fallback probe table Jeremy Linton
2016-03-16 21:39 ` nleeder at codeaurora.org
2016-03-13 23:23 ` [PATCH 3/4] arm64: pmu: Add support for probing with ACPI Jeremy Linton
2016-03-13 23:28 ` Timur Tabi
2016-03-14 1:44 ` Jeremy Linton
2016-03-13 23:23 ` [PATCH 4/4] arm64: pmu: add A72 cpu type, support multiple PMU types Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457911398-22412-2-git-send-email-jeremy.linton@arm.com \
--to=jeremy.linton@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).