linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: david@lechnology.com (David Lechner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] mmc: davinci: prepare clock
Date: Mon, 14 Mar 2016 17:54:39 -0500	[thread overview]
Message-ID: <1457996081-21975-4-git-send-email-david@lechnology.com> (raw)
In-Reply-To: <1457996081-21975-1-git-send-email-david@lechnology.com>

When trying to use this driver with the common clock framework, enabling
the clock fails because it was not prepared. This fixes the problem by
calling clk_prepare and clk_enable in a single function. Ditto for
clk_disable_unprepare.

Signed-off-by: David Lechner <david@lechnology.com>
---

v2 changes: use clk_disable_unprepare where applicable. 


 drivers/mmc/host/davinci_mmc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 6dd9562..8d10a92 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1273,9 +1273,9 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev)
 		ret = PTR_ERR(host->clk);
 		goto clk_get_fail;
 	}
-	ret = clk_enable(host->clk);
+	ret = clk_prepare_enable(host->clk);
 	if (ret)
-		goto clk_enable_fail;
+		goto clk_prepare_enable_fail;
 
 	host->mmc_input_clk = clk_get_rate(host->clk);
 
@@ -1375,8 +1375,8 @@ mmc_add_host_fail:
 	mmc_davinci_cpufreq_deregister(host);
 cpu_freq_fail:
 	davinci_release_dma_channels(host);
-	clk_disable(host->clk);
-clk_enable_fail:
+	clk_disable_unprepare(host->clk);
+clk_prepare_enable_fail:
 clk_get_fail:
 ioremap_fail:
 	mmc_free_host(mmc);
@@ -1391,7 +1391,7 @@ static int __exit davinci_mmcsd_remove(struct platform_device *pdev)
 	mmc_remove_host(host->mmc);
 	mmc_davinci_cpufreq_deregister(host);
 	davinci_release_dma_channels(host);
-	clk_disable(host->clk);
+	clk_disable_unprepare(host->clk);
 	mmc_free_host(host->mmc);
 
 	return 0;
-- 
1.9.1

  parent reply	other threads:[~2016-03-14 22:54 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 23:50 [PATCH 0/4] davinci_mmc device tree fixes David Lechner
2016-03-09 23:50 ` [PATCH 1/4] mmc: davinci: remove matching string David Lechner
2016-03-14 13:41   ` Sekhar Nori
2016-03-09 23:50 ` [PATCH 2/4] mmc: davinci: fix unwinding in probe David Lechner
2016-03-14 11:52   ` Sekhar Nori
2016-03-09 23:50 ` [PATCH 3/4] mmc: davinci: prepare clock David Lechner
2016-03-14 11:54   ` Sekhar Nori
2016-03-14 17:09     ` David Lechner
2016-03-14 17:13       ` David Lechner
2016-03-15  5:16       ` Sekhar Nori
2016-03-09 23:50 ` [PATCH 4/4] mmc: davinci: suppress waring when using DT David Lechner
2016-03-14 13:41   ` Sekhar Nori
2016-03-14 22:54     ` [PATCH v2 0/5] davinci_mmc fixes David Lechner
2016-03-14 22:54       ` [PATCH v2 1/5] mmc: davinci: remove matching string David Lechner
2016-03-15  9:12         ` Sekhar Nori
2016-03-14 22:54       ` [PATCH v2 2/5] mmc: davinci: fix unwinding in probe David Lechner
2016-03-15  9:10         ` Sekhar Nori
2016-03-14 22:54       ` David Lechner [this message]
2016-03-15  9:13         ` [PATCH v2 3/5] mmc: davinci: prepare clock Sekhar Nori
2016-03-14 22:54       ` [PATCH v2 4/5] mmc: davinci: don't use dma platform resources David Lechner
2016-03-15  8:09         ` Sekhar Nori
2016-03-15  8:54         ` Peter Ujfalusi
2016-03-15  8:56           ` Peter Ujfalusi
2016-03-15 17:14           ` David Lechner
2016-03-16  8:46             ` Peter Ujfalusi
2016-03-14 22:54       ` [PATCH v2 5/5] arm: davinci: remove mmc dma resources David Lechner
2016-03-15  8:23         ` Sekhar Nori
2016-03-15  8:13       ` [PATCH v2 0/5] davinci_mmc fixes Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457996081-21975-4-git-send-email-david@lechnology.com \
    --to=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).