linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
@ 2016-03-21 22:13 Hans de Goede
  2016-03-22  0:33 ` Javier Martinez Canillas
  2016-03-22 20:12 ` Andreas Färber
  0 siblings, 2 replies; 4+ messages in thread
From: Hans de Goede @ 2016-03-21 22:13 UTC (permalink / raw)
  To: linux-arm-kernel

Add a missing MODULE_DEVICE_TABLE() line which was causing the
sunxi-musb glue to not auto-load when build as a module.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/usb/musb/sunxi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
index 4b472b8..9af9431 100644
--- a/drivers/usb/musb/sunxi.c
+++ b/drivers/usb/musb/sunxi.c
@@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
 	{ .compatible = "allwinner,sun8i-a33-musb", },
 	{}
 };
+MODULE_DEVICE_TABLE(of, sunxi_musb_match);
 
 static struct platform_driver sunxi_musb_driver = {
 	.probe = sunxi_musb_probe,
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
  2016-03-21 22:13 [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading Hans de Goede
@ 2016-03-22  0:33 ` Javier Martinez Canillas
  2016-03-22 20:12 ` Andreas Färber
  1 sibling, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-03-22  0:33 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Mar 21, 2016 at 7:13 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> Add a missing MODULE_DEVICE_TABLE() line which was causing the
> sunxi-musb glue to not auto-load when build as a module.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
  2016-03-21 22:13 [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading Hans de Goede
  2016-03-22  0:33 ` Javier Martinez Canillas
@ 2016-03-22 20:12 ` Andreas Färber
  2016-03-22 20:52   ` [linux-sunxi] " Hans de Goede
  1 sibling, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2016-03-22 20:12 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Hans,

Am 21.03.2016 um 23:13 schrieb Hans de Goede:
> Add a missing MODULE_DEVICE_TABLE() line which was causing the
> sunxi-musb glue to not auto-load when build as a module.

"built"

> 

Should this get a Fixes: header for backporting to stable?

> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/usb/musb/sunxi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
> index 4b472b8..9af9431 100644
> --- a/drivers/usb/musb/sunxi.c
> +++ b/drivers/usb/musb/sunxi.c
> @@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
>  	{ .compatible = "allwinner,sun8i-a33-musb", },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, sunxi_musb_match);
>  
>  static struct platform_driver sunxi_musb_driver = {
>  	.probe = sunxi_musb_probe,

Has anyone looked into my earlier report about the module filename not
having musb-? I did not see any response and haven't rechecked v4.5.0.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N?rnberg)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [linux-sunxi] Re: [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading
  2016-03-22 20:12 ` Andreas Färber
@ 2016-03-22 20:52   ` Hans de Goede
  0 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2016-03-22 20:52 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 22-03-16 21:12, Andreas F?rber wrote:
> Hi Hans,
>
> Am 21.03.2016 um 23:13 schrieb Hans de Goede:
>> Add a missing MODULE_DEVICE_TABLE() line which was causing the
>> sunxi-musb glue to not auto-load when build as a module.
>
> "built"

Thanks.

> Should this get a Fixes: header for backporting to stable?

Actually while looking for the commit id, it looks like someone
else has already beat me to it, and this is already fixes
in Linus' tree, so self NACK for this one.

Regards,

Hans


>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   drivers/usb/musb/sunxi.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/sunxi.c b/drivers/usb/musb/sunxi.c
>> index 4b472b8..9af9431 100644
>> --- a/drivers/usb/musb/sunxi.c
>> +++ b/drivers/usb/musb/sunxi.c
>> @@ -756,6 +756,7 @@ static const struct of_device_id sunxi_musb_match[] = {
>>   	{ .compatible = "allwinner,sun8i-a33-musb", },
>>   	{}
>>   };
>> +MODULE_DEVICE_TABLE(of, sunxi_musb_match);
>>
>>   static struct platform_driver sunxi_musb_driver = {
>>   	.probe = sunxi_musb_probe,
>
> Has anyone looked into my earlier report about the module filename not
> having musb-? I did not see any response and haven't rechecked v4.5.0.
>
> Regards,
> Andreas
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-22 20:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-21 22:13 [PATCH] musb: sunxi-glue: Fix sunxi-musb driver not auto-loading Hans de Goede
2016-03-22  0:33 ` Javier Martinez Canillas
2016-03-22 20:12 ` Andreas Färber
2016-03-22 20:52   ` [linux-sunxi] " Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).