From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/4] fix memremap on ARM
Date: Thu, 31 Mar 2016 11:18:48 +0200 [thread overview]
Message-ID: <1459415932-17852-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
This is something I ran into while working on support for the UEFI
memory attributes and ESRT tables. In both cases, these tables are
passed to the kernel in memory which is guaranteed to be below 4 GB,
but may be outside of the kernel direct mapping. (UEFI typically
attempts to allocate from the top down, which means such tables are
highly likely to be in highmem for any system with more than 760 MB
of system RAM)
The recently introduced memremap() is a very useful abstraction for
accessing such tables, because it is generic, and already attempts to
do the right thing with respect to regions that may already have been
mapped directly. However, it falls back to ioremap_cache() for mapping
high memory, which is not allowed on ARM for system RAM, and also results
in the region to be mapped with different attributes depending on whether
it is covered by lowmem or not.
So instead, create an arch specific hook 'arch_memremap_wb(), and
implement it for ARM using the same memory attributes used for the
linear mapping. Note that memremap will only call this hook for regions
that are not already mapped permanently.
Since this change results in memremap() to use attributes different from
the ones used by ioremap_cache(), revert the change to pxa2xx-flash that
moved it to memremap.
Changes since v3:
- fix inadvertent logic change, where a arch_memremap_wb() would only be
attempted on a region that intersects System RAM
Changes since v2:
- add patch to bring back ioremap_cached() on ARM
- switch pxa2xx-flash back to ioremap_cached() not ioremap_cache()
- use arch_ioremap_caller not __arm_ioremap_caller() in patch #4
- deal with __iomem annotation of arch_ioremap_caller (patch #4)
Changes since v1/rfc:
- new patch #1 that reverts the ioremap_cache->memremap conversion for the
pxa2xx-flash driver
- added Dan's ack to patch #2
Ard Biesheuvel (4):
ARM: reintroduce ioremap_cached() for creating cached I/O mappings
mtd: pxa2xx-flash: switch back from memremap to ioremap_cached
memremap: add arch specific hook for MEMREMAP_WB mappings
ARM: memremap: implement arch_memremap_wb()
arch/arm/include/asm/io.h | 12 ++++++++++++
arch/arm/mm/ioremap.c | 16 ++++++++++++++--
drivers/mtd/maps/pxa2xx-flash.c | 6 +++---
kernel/memremap.c | 11 +++++++++--
4 files changed, 38 insertions(+), 7 deletions(-)
--
2.5.0
next reply other threads:[~2016-03-31 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:18 Ard Biesheuvel [this message]
2016-03-31 9:18 ` [PATCH v4 1/4] ARM: reintroduce ioremap_cached() for creating cached I/O mappings Ard Biesheuvel
2016-03-31 9:18 ` [PATCH v4 2/4] mtd: pxa2xx-flash: switch back from memremap to ioremap_cached Ard Biesheuvel
2016-03-31 9:18 ` [PATCH v4 3/4] memremap: add arch specific hook for MEMREMAP_WB mappings Ard Biesheuvel
2016-03-31 9:18 ` [PATCH v4 4/4] ARM: memremap: implement arch_memremap_wb() Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459415932-17852-1-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).