public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/3] ahci: add ports-implemented dt bindings
Date: Fri,  1 Apr 2016 08:52:55 +0100	[thread overview]
Message-ID: <1459497178-31090-1-git-send-email-srinivas.kandagatla@linaro.org> (raw)

Hi Tejun,

On some SOCs PORTS_IMPL register value is never programmed by the BIOS
and left at zero value. Which means that no sata ports are available for
software. AHCI driver used to cope up with this by fabricating the
port_map if the PORTS_IMPL register is read zero, but recent patch [1]
broke this workaround as zero value was valid for nvme disks.

This patch adds ports-implemented dt bindings as workaround for this issue
in a way that DT can dictate the port_map incase where the SOCs does not
program it already.

Am sure that there are more than one SOC that hits this issue.

Without this patchset, ACHI on APQ8064 Qualcomm platform is broken in mainline.
With the below patchset am able to get back the functionality.

Can you take all the patches via libata tree, I have collected the
acks required for DT.

Changes since v2:
	- reordered compatible strings in DT spotted by Sergei.

Changes since RFC:
	- Remove DT example as suggested by Rob.
	- Fixed comments on DT binding patch as suggested by Rob.
	- removed unused variable spotted by kernel test robot.

Thanks,
srini
[1] 566d18 "libata: disable forced PORTS_IMPL for >= AHCI 1.3"

Srinivas Kandagatla (3):
  libahci: save port map for forced port map
  ata: ahci-platform: Add ports-implemented DT bindings.
  ARM: dts: apq8064: add ahci ports-implemented mask

 Documentation/devicetree/bindings/ata/ahci-platform.txt | 4 ++++
 arch/arm/boot/dts/qcom-apq8064.dtsi                     | 3 ++-
 drivers/ata/ahci_platform.c                             | 3 +++
 drivers/ata/libahci.c                                   | 1 +
 4 files changed, 10 insertions(+), 1 deletion(-)

-- 
2.5.0

             reply	other threads:[~2016-04-01  7:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  7:52 Srinivas Kandagatla [this message]
2016-04-01  7:52 ` [PATCH v3 1/3] libahci: save port map for forced port map Srinivas Kandagatla
2016-04-01  7:52 ` [PATCH v3 2/3] ata: ahci-platform: Add ports-implemented DT bindings Srinivas Kandagatla
2016-04-04  5:15   ` Rob Herring
2016-04-01  7:52 ` [PATCH v3 3/3] ARM: dts: apq8064: add ahci ports-implemented mask Srinivas Kandagatla
2016-04-01 14:44 ` [PATCH v3 0/3] ahci: add ports-implemented dt bindings Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459497178-31090-1-git-send-email-srinivas.kandagatla@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox