[PATCH] ARM: dts: armv7-m: add address to unit name

[PATCH] ARM: dts: armv7-m: add address to unit name

[Stefan Agner]

Add address to unit name to remove the following warning:
 Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
 reg or ranges property, but no unit name

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Hi Arnd,

Not sure through which tree this should go but an earlier patch
seemd to be applied directly by you...

--
Stefan

 arch/arm/boot/dts/armv7-m.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
index b1ad7cf..8126bec 100644
--- a/arch/arm/boot/dts/armv7-m.dtsi
+++ b/arch/arm/boot/dts/armv7-m.dtsi
@@ -1,7 +1,7 @@
 #include "skeleton.dtsi"
 
 / {
-	nvic: nv-interrupt-controller  {
+	nvic: nv-interrupt-controller at 0xe000e100 {
 		compatible = "arm,armv7m-nvic";
 		interrupt-controller;
 		#interrupt-cells = <1>;
-- 
2.7.4

[PATCH] ARM: dts: armv7-m: add address to unit name

[Joachim Eastwood]

On 2 April 2016 at 08:08, Stefan Agner <stefan@agner.ch> wrote:
> Add address to unit name to remove the following warning:
>  Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
>  reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
>  arch/arm/boot/dts/armv7-m.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
>  #include "skeleton.dtsi"
>
>  / {
> -       nvic: nv-interrupt-controller  {
> +       nvic: nv-interrupt-controller at 0xe000e100 {

While changing the line it might be good idea to use the standard
'interrupt-controller' name instead.

I posted the same patch couple of days ago, btw.
http://marc.info/?l=devicetree&m=145929088915714&w=2


But I don't care which one that is applied.

regards,
Joachim Eastwood

[PATCH] ARM: dts: armv7-m: add address to unit name

[Sergei Shtylyov]

Hello.

On 4/2/2016 9:08 AM, Stefan Agner wrote:

> Add address to unit name to remove the following warning:
>   Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
>   reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
>   arch/arm/boot/dts/armv7-m.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
>   #include "skeleton.dtsi"
>
>   / {
> -	nvic: nv-interrupt-controller  {
> +	nvic: nv-interrupt-controller at 0xe000e100 {

    Drop "0x" from <unit address> please. And the name should be just 
"interrupt-controller at ..."

WBR, Sergei