* [PATCH] ARM: dts: armv7-m: add address to unit name
@ 2016-04-02 6:08 Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
2016-04-02 16:12 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Agner @ 2016-04-02 6:08 UTC (permalink / raw)
To: linux-arm-kernel
Add address to unit name to remove the following warning:
Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
reg or ranges property, but no unit name
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
Hi Arnd,
Not sure through which tree this should go but an earlier patch
seemd to be applied directly by you...
--
Stefan
arch/arm/boot/dts/armv7-m.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
index b1ad7cf..8126bec 100644
--- a/arch/arm/boot/dts/armv7-m.dtsi
+++ b/arch/arm/boot/dts/armv7-m.dtsi
@@ -1,7 +1,7 @@
#include "skeleton.dtsi"
/ {
- nvic: nv-interrupt-controller {
+ nvic: nv-interrupt-controller at 0xe000e100 {
compatible = "arm,armv7m-nvic";
interrupt-controller;
#interrupt-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: armv7-m: add address to unit name
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
@ 2016-04-02 13:41 ` Joachim Eastwood
2016-04-02 16:12 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Joachim Eastwood @ 2016-04-02 13:41 UTC (permalink / raw)
To: linux-arm-kernel
On 2 April 2016 at 08:08, Stefan Agner <stefan@agner.ch> wrote:
> Add address to unit name to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
> reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
> arch/arm/boot/dts/armv7-m.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
> #include "skeleton.dtsi"
>
> / {
> - nvic: nv-interrupt-controller {
> + nvic: nv-interrupt-controller at 0xe000e100 {
While changing the line it might be good idea to use the standard
'interrupt-controller' name instead.
I posted the same patch couple of days ago, btw.
http://marc.info/?l=devicetree&m=145929088915714&w=2
But I don't care which one that is applied.
regards,
Joachim Eastwood
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: armv7-m: add address to unit name
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
@ 2016-04-02 16:12 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2016-04-02 16:12 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 4/2/2016 9:08 AM, Stefan Agner wrote:
> Add address to unit name to remove the following warning:
> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a
> reg or ranges property, but no unit name
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> Hi Arnd,
>
> Not sure through which tree this should go but an earlier patch
> seemd to be applied directly by you...
>
> --
> Stefan
>
> arch/arm/boot/dts/armv7-m.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi
> index b1ad7cf..8126bec 100644
> --- a/arch/arm/boot/dts/armv7-m.dtsi
> +++ b/arch/arm/boot/dts/armv7-m.dtsi
> @@ -1,7 +1,7 @@
> #include "skeleton.dtsi"
>
> / {
> - nvic: nv-interrupt-controller {
> + nvic: nv-interrupt-controller at 0xe000e100 {
Drop "0x" from <unit address> please. And the name should be just
"interrupt-controller at ..."
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-02 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-02 6:08 [PATCH] ARM: dts: armv7-m: add address to unit name Stefan Agner
2016-04-02 13:41 ` Joachim Eastwood
2016-04-02 16:12 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).