From: yong.wu@mediatek.com (Yong Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] iommu/dma: Finish optimising higher-order allocations
Date: Fri, 8 Apr 2016 13:32:48 +0800 [thread overview]
Message-ID: <1460093568.18911.6.camel@mhfsdcap03> (raw)
In-Reply-To: <89763f6b1ac684c3d8712e38760bec55b7885e3b.1460048991.git.robin.murphy@arm.com>
On Thu, 2016-04-07 at 18:42 +0100, Robin Murphy wrote:
> /*
> @@ -215,8 +221,9 @@ static struct page **__iommu_dma_alloc_pages(unsigned int count, gfp_t gfp)
> * than a necessity, hence using __GFP_NORETRY until
> * falling back to single-page allocations.
> */
> - for (order = min_t(unsigned int, order, __fls(count));
> - order > 0; order--) {
> + for (pgsize_orders &= (2U << __fls(count)) - 1;
> + (order = __fls(pgsize_orders)) > min_order;
> + pgsize_orders &= (1U << order) - 1) {
> page = alloc_pages(gfp | __GFP_NORETRY, order);
> if (!page)
> continue;
> @@ -230,7 +237,7 @@ static struct page **__iommu_dma_alloc_pages(unsigned int count, gfp_t gfp)
> }
> }
> if (!page)
> - page = alloc_page(gfp);
> + page = alloc_pages(gfp, order);
A small question: Do we need split it too if order != 0 here?
> if (!page) {
> __iommu_dma_free_pages(pages, i);
> return NULL;
[...]
next prev parent reply other threads:[~2016-04-08 5:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:42 [PATCH 0/5] Introduce per-domain page sizes Robin Murphy
2016-04-07 17:42 ` [PATCH 1/5] iommu: remove unused priv field from struct iommu_ops Robin Murphy
2016-04-07 17:42 ` [PATCH 2/5] iommu: of: enforce const-ness of " Robin Murphy
2016-04-07 17:42 ` [PATCH 3/5] iommu: Allow selecting page sizes per domain Robin Murphy
2016-04-07 17:42 ` [PATCH 4/5] iommu/dma: Finish optimising higher-order allocations Robin Murphy
2016-04-08 5:32 ` Yong Wu [this message]
2016-04-08 16:33 ` Robin Murphy
2016-04-13 16:29 ` [PATCH v2] " Robin Murphy
2016-04-21 5:47 ` Yong Wu
2016-04-07 17:42 ` [PATCH 5/5] iommu/arm-smmu: Use per-domain page sizes Robin Murphy
2016-04-21 16:38 ` [PATCH 0/5] Introduce " Will Deacon
2016-05-09 11:21 ` Joerg Roedel
2016-05-09 11:45 ` Robin Murphy
2016-05-09 14:51 ` Joerg Roedel
2016-05-09 15:18 ` Robin Murphy
2016-05-09 15:50 ` Joerg Roedel
2016-05-09 16:20 ` [PATCH v2] iommu/arm-smmu: Use " Robin Murphy
2016-05-10 9:45 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460093568.18911.6.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).