From: henryc.chen@mediatek.com (Henry Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove.
Date: Fri, 8 Apr 2016 14:58:48 +0800 [thread overview]
Message-ID: <1460098729-25549-2-git-send-email-henryc.chen@mediatek.com> (raw)
In-Reply-To: <1460098729-25549-1-git-send-email-henryc.chen@mediatek.com>
It is possible that pmic->irq_domain will be NULL in fail_irq error handling.
Check before calling irq_domain_remove.
Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
drivers/mfd/mt6397-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
index a879223..15050cb 100644
--- a/drivers/mfd/mt6397-core.c
+++ b/drivers/mfd/mt6397-core.c
@@ -312,7 +312,8 @@ static int mt6397_probe(struct platform_device *pdev)
fail_irq:
if (ret) {
- irq_domain_remove(pmic->irq_domain);
+ if (pmic->irq_domain)
+ irq_domain_remove(pmic->irq_domain);
dev_err(&pdev->dev, "failed to add child devices: %d\n", ret);
}
--
1.8.1.1.dirty
next prev parent reply other threads:[~2016-04-08 6:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 6:58 [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Henry Chen
2016-04-08 6:58 ` Henry Chen [this message]
2016-04-11 8:53 ` [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove Lee Jones
2016-04-08 6:58 ` [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq Henry Chen
2016-04-11 8:50 ` Lee Jones
2016-04-13 5:48 ` Henry Chen
2016-04-11 8:56 ` [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460098729-25549-2-git-send-email-henryc.chen@mediatek.com \
--to=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).