From mboxrd@z Thu Jan 1 00:00:00 1970 From: henryc.chen@mediatek.com (Henry Chen) Date: Fri, 8 Apr 2016 14:58:48 +0800 Subject: [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove. In-Reply-To: <1460098729-25549-1-git-send-email-henryc.chen@mediatek.com> References: <1460098729-25549-1-git-send-email-henryc.chen@mediatek.com> Message-ID: <1460098729-25549-2-git-send-email-henryc.chen@mediatek.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org It is possible that pmic->irq_domain will be NULL in fail_irq error handling. Check before calling irq_domain_remove. Signed-off-by: Henry Chen --- drivers/mfd/mt6397-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c index a879223..15050cb 100644 --- a/drivers/mfd/mt6397-core.c +++ b/drivers/mfd/mt6397-core.c @@ -312,7 +312,8 @@ static int mt6397_probe(struct platform_device *pdev) fail_irq: if (ret) { - irq_domain_remove(pmic->irq_domain); + if (pmic->irq_domain) + irq_domain_remove(pmic->irq_domain); dev_err(&pdev->dev, "failed to add child devices: %d\n", ret); } -- 1.8.1.1.dirty