From: henryc.chen@mediatek.com (Henry Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq.
Date: Wed, 13 Apr 2016 13:48:21 +0800 [thread overview]
Message-ID: <1460526501.32184.4.camel@mtksdaap41> (raw)
In-Reply-To: <20160411085039.GL4592@x1>
On Mon, 2016-04-11 at 09:50 +0100, Lee Jones wrote:
> On Fri, 08 Apr 2016, Henry Chen wrote:
>
> > If get the -EPROBE_DEFER from platform_get_irq, it should return back directly.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > drivers/mfd/mt6397-core.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> > index 15050cb..b9b1e28 100644
> > --- a/drivers/mfd/mt6397-core.c
> > +++ b/drivers/mfd/mt6397-core.c
> > @@ -271,6 +271,8 @@ static int mt6397_probe(struct platform_device *pdev)
> > }
> >
> > pmic->irq = platform_get_irq(pdev, 0);
> > + if (pmic->irq == -EPROBE_DEFER)
> > + return -EPROBE_DEFER;
>
> if (ret < 0)
> return ret;
>
> ... is more common, as it covers more bases, etc.
Okay, the interrupt should be a required properties, if get failed just
return back.
I will also change the binding doc.
Thanks.
>
> > switch (id & 0xff) {
> > case MT6323_CID_CODE:
>
next prev parent reply other threads:[~2016-04-13 5:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 6:58 [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Henry Chen
2016-04-08 6:58 ` [PATCH v2 2/3] mfd: mt6397: Checking for null before irq_domain_remove Henry Chen
2016-04-11 8:53 ` Lee Jones
2016-04-08 6:58 ` [PATCH v2 3/3] mfd: mt6397: check the EPROBE_DEFER from platform_get_irq Henry Chen
2016-04-11 8:50 ` Lee Jones
2016-04-13 5:48 ` Henry Chen [this message]
2016-04-11 8:56 ` [PATCH v2 1/3] mfd: mt6397: irq domain should initialize before mfd_add_devices() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460526501.32184.4.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox