linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hongzhou.yang@mediatek.com (Hongzhou Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce
Date: Wed, 13 Apr 2016 10:30:03 -0700	[thread overview]
Message-ID: <1460568603.16516.0.camel@mussux00> (raw)
In-Reply-To: <1459580269-64531-1-git-send-email-yingjoe.chen@mediatek.com>

On Sat, 2016-04-02 at 14:57 +0800, Yingjoe Chen wrote:
> The debounce time unit for gpio_chip.set_debounce is us but
> mtk_gpio_set_debounce regard it as ms.
> Fix this by correct debounce time array dbnc_arr so it can find correct
> debounce setting. Debounce time for first debounce setting is 500us,
> correct this as well.
> 
> While I'm at it, also change the debounce time array name to
> "debounce_time" for readability.
> 
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>

Acked-by: Hongzhou Yang <hongzhou.yang@mediatek.com>

> ---
> This was based on v4.6-rc1
> Change since v1:
> - Improve commit message.
> - Change dbnc_arr name to debounce_time
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> index 2bbe6f7..6ab8c3c 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> @@ -1004,7 +1004,8 @@ static int mtk_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
>  	struct mtk_pinctrl *pctl = dev_get_drvdata(chip->parent);
>  	int eint_num, virq, eint_offset;
>  	unsigned int set_offset, bit, clr_bit, clr_offset, rst, i, unmask, dbnc;
> -	static const unsigned int dbnc_arr[] = {0 , 1, 16, 32, 64, 128, 256};
> +	static const unsigned int debounce_time[] = {500, 1000, 16000, 32000, 64000,
> +						128000, 256000};
>  	const struct mtk_desc_pin *pin;
>  	struct irq_data *d;
>  
> @@ -1022,9 +1023,9 @@ static int mtk_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,
>  	if (!mtk_eint_can_en_debounce(pctl, eint_num))
>  		return -ENOSYS;
>  
> -	dbnc = ARRAY_SIZE(dbnc_arr);
> -	for (i = 0; i < ARRAY_SIZE(dbnc_arr); i++) {
> -		if (debounce <= dbnc_arr[i]) {
> +	dbnc = ARRAY_SIZE(debounce_time);
> +	for (i = 0; i < ARRAY_SIZE(debounce_time); i++) {
> +		if (debounce <= debounce_time[i]) {
>  			dbnc = i;
>  			break;
>  		}

  parent reply	other threads:[~2016-04-13 17:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-02  6:57 [PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce Yingjoe Chen
2016-04-08 11:01 ` Daniel Kurtz
2016-04-13 17:30 ` Hongzhou Yang [this message]
2016-04-15  8:29 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460568603.16516.0.camel@mussux00 \
    --to=hongzhou.yang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).