linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [RFC PATCH v2 5/5] ASoC: mediatek: Add mt2701-cs42448 driver and config option.
Date: Thu, 14 Apr 2016 20:39:34 +0800	[thread overview]
Message-ID: <1460637574.13240.19.camel@mtksdaap41> (raw)
In-Reply-To: <1460636070-37426-6-git-send-email-garlic.tseng@mediatek.com>

On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote:
> Add machine driver and config option for MT2701.
> 
> Signed-off-by: Garlic Tseng <garlic.tseng@mediatek.com>
> ---
>  sound/soc/mediatek/Kconfig                 |  21 ++
>  sound/soc/mediatek/Makefile                |   3 +
>  sound/soc/mediatek/mt2701/Makefile         |  20 ++
>  sound/soc/mediatek/mt2701/mt2701-cs42448.c | 376 +++++++++++++++++++++++++++++
>  4 files changed, 420 insertions(+)
>  create mode 100644 sound/soc/mediatek/mt2701/Makefile
>  create mode 100644 sound/soc/mediatek/mt2701/mt2701-cs42448.c
> 
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index f7e789e..b190322 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -48,3 +48,24 @@ config SND_SOC_MT8173_RT5650_RT5676
>  	  with the RT5650 and RT5676 codecs.
>  	  Select Y if you have such device.
>  	  If unsure select "N".
> +
> +config SND_SOC_MT2701

It seems we need different driver for different soc. So after this
patch, SND_SOC_MEDIATEK only select driver for mt8173. Maybe it should
be renamed to SND_SOC_MT8173 to reflect this.

> +	bool "SND_SOC_MT2701"


Please check other config in this file and have a proper config prompt
here.

Can we support module like mt8173?

> +	depends on SND_SOC_MEDIATEK
> +	select SND_SOC_CS42XX8_I2C
> +	help
> +	  This adds ASoC driver for Mediatek MT2701 boards
> +	  with the CS42448 codecs.
> +	  Select Y if you have such device.
> +	  If unsure select "N".


Based on the Makefile, this is platform driver for mt2701. This should
not depends on codec. Please update the help message and select.

> +
> +config SND_SOC_MT2701_CS42448
> +	bool "SND_SOC_MT2701_CS42448"
> +	depends on SND_SOC_MT2701
> +	select SND_SOC_CS42XX8_I2C
> +	help
> +	  This adds ASoC driver for Mediatek MT2701 boards
> +	  with the CS42448 codecs.
> +	  Select Y if you have such device.
> +	  If unsure select "N".
> +
> diff --git a/sound/soc/mediatek/Makefile b/sound/soc/mediatek/Makefile
> index 5048165..60387ca 100644
> --- a/sound/soc/mediatek/Makefile
> +++ b/sound/soc/mediatek/Makefile
> @@ -3,3 +3,6 @@ obj-$(CONFIG_SND_SOC_MT8173_MAX98090) += mt8173/
>  obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5676) += mt8173/
>  obj-$(CONFIG_SND_SOC_MT8173_RT5650_RT5514) += mt8173/
>  obj-$(CONFIG_SND_SOC_MT8173_RT5650) += mt8173/
> +
> +# 2701 Machine support
> +obj-$(CONFIG_SND_SOC_MT2701_CS42448) += mt2701/

Sorting, please put mt2701 before mt8173.

Joe.C

  reply	other threads:[~2016-04-14 12:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14 12:14 [alsa-devel] [RFC PATCH v2 0/5] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-04-14 12:14 ` [alsa-devel] [RFC PATCH v2 1/5] ASoC: Mediatek: Refine mt8173 driver Garlic Tseng
2016-04-14 12:44   ` Yingjoe Chen
2016-04-15  1:56     ` Garlic Tseng
2016-04-14 12:14 ` [alsa-devel] [RFC PATCH v2 2/5] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-04-20 10:36   ` Matthias Brugger
2016-04-21  1:40     ` Garlic Tseng
2016-04-14 12:14 ` [alsa-devel] [RFC PATCH v2 3/5] ASoC: mediatek: add clock and irq control for 2701 platform driver Garlic Tseng
2016-04-14 12:14 ` [alsa-devel] [RFC PATCH v2 4/5] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-04-14 12:14 ` [alsa-devel] [RFC PATCH v2 5/5] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
2016-04-14 12:39   ` Yingjoe Chen [this message]
2016-04-15  1:45     ` YiMing (Garlic) Tseng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460637574.13240.19.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).