From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare
Date: Thu, 14 Apr 2016 20:53:32 +0800 [thread overview]
Message-ID: <1460638414-5987-3-git-send-email-jszhang@marvell.com> (raw)
In-Reply-To: <1460638414-5987-1-git-send-email-jszhang@marvell.com>
If i2c_dw_probe() fail, we should call i2c_dw_plat_prepare_clk() to
disable and unprepare the clk, otherwise the clk enable and prepare
is left unbalanced.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 00f9e99..1488cea 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -268,6 +268,8 @@ rpm_disable:
pm_runtime_put_noidle(&pdev->dev);
}
+ i2c_dw_plat_prepare_clk(dev, false);
+
return r;
}
--
2.8.0.rc3
next prev parent reply other threads:[~2016-04-14 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 12:53 [PATCH 0/4] i2c: designware: runtime pm fix and improve Jisheng Zhang
2016-04-14 12:53 ` [PATCH 1/4] i2c: designware-platdrv: Fix runtime PM initialization Jisheng Zhang
2016-04-20 13:53 ` Jarkko Nikula
2016-04-21 3:08 ` Jisheng Zhang
2016-04-21 7:48 ` Jarkko Nikula
2016-04-21 8:15 ` Jisheng Zhang
2016-04-14 12:53 ` Jisheng Zhang [this message]
2016-04-20 12:55 ` [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare Jarkko Nikula
2016-04-20 14:16 ` Andy Shevchenko
2016-04-21 2:40 ` Jisheng Zhang
2016-04-21 7:39 ` Jarkko Nikula
2016-04-21 8:19 ` Jisheng Zhang
2016-04-14 12:53 ` [PATCH 3/4] i2c: designware-pcidrv: enable RuntimePM before registering to the core Jisheng Zhang
2016-04-20 13:03 ` Jarkko Nikula
2016-04-14 12:53 ` [PATCH 4/4] i2c: designware: remove runtime suspend prevention during registration Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460638414-5987-3-git-send-email-jszhang@marvell.com \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).