* [PATCH] ARM: dts: omap3: Fix ISP syscon register offset
@ 2016-04-16 6:20 Ivaylo Dimitrov
2016-04-22 4:34 ` Ivaylo Dimitrov
0 siblings, 1 reply; 4+ messages in thread
From: Ivaylo Dimitrov @ 2016-04-16 6:20 UTC (permalink / raw)
To: linux-arm-kernel
According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/boot/dts/omap34xx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
index 5cdba1f..e446562 100644
--- a/arch/arm/boot/dts/omap34xx.dtsi
+++ b/arch/arm/boot/dts/omap34xx.dtsi
@@ -46,7 +46,7 @@
0x480bd800 0x017c>;
interrupts = <24>;
iommus = <&mmu_isp>;
- syscon = <&scm_conf 0xdc>;
+ syscon = <&scm_conf 0x6c>;
ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
#clock-cells = <1>;
ports {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: omap3: Fix ISP syscon register offset
2016-04-16 6:20 [PATCH] ARM: dts: omap3: Fix ISP syscon register offset Ivaylo Dimitrov
@ 2016-04-22 4:34 ` Ivaylo Dimitrov
2016-04-22 13:16 ` Sebastian Reichel
0 siblings, 1 reply; 4+ messages in thread
From: Ivaylo Dimitrov @ 2016-04-22 4:34 UTC (permalink / raw)
To: linux-arm-kernel
On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> index 5cdba1f..e446562 100644
> --- a/arch/arm/boot/dts/omap34xx.dtsi
> +++ b/arch/arm/boot/dts/omap34xx.dtsi
> @@ -46,7 +46,7 @@
> 0x480bd800 0x017c>;
> interrupts = <24>;
> iommus = <&mmu_isp>;
> - syscon = <&scm_conf 0xdc>;
> + syscon = <&scm_conf 0x6c>;
> ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> #clock-cells = <1>;
> ports {
>
Anyone going to review that?
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: omap3: Fix ISP syscon register offset
2016-04-22 4:34 ` Ivaylo Dimitrov
@ 2016-04-22 13:16 ` Sebastian Reichel
2016-04-26 17:12 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Reichel @ 2016-04-22 13:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Fri, Apr 22, 2016 at 07:34:43AM +0300, Ivaylo Dimitrov wrote:
> On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> >According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
> >
> >Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> >---
> > arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> >index 5cdba1f..e446562 100644
> >--- a/arch/arm/boot/dts/omap34xx.dtsi
> >+++ b/arch/arm/boot/dts/omap34xx.dtsi
> >@@ -46,7 +46,7 @@
> > 0x480bd800 0x017c>;
> > interrupts = <24>;
> > iommus = <&mmu_isp>;
> >- syscon = <&scm_conf 0xdc>;
> >+ syscon = <&scm_conf 0x6c>;
> > ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> > #clock-cells = <1>;
> > ports {
> >
You may want to add the hint, that 0xdc (the old, wrong "offset")
represents the last few bits of the register address. I guess
somebody didn't notice, that scm_conf does not start at a register
address ending with 00 (like most other modules).
Reviewed-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160422/c05cb73e/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: omap3: Fix ISP syscon register offset
2016-04-22 13:16 ` Sebastian Reichel
@ 2016-04-26 17:12 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2016-04-26 17:12 UTC (permalink / raw)
To: linux-arm-kernel
* Sebastian Reichel <sre@kernel.org> [160422 06:17]:
> Hi,
>
> On Fri, Apr 22, 2016 at 07:34:43AM +0300, Ivaylo Dimitrov wrote:
> > On 16.04.2016 09:20, Ivaylo Dimitrov wrote:
> > >According to the TRM, SCM CONTROL_CSIRXFE register is on offset 0x6c
> > >
> > >Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > >---
> > > arch/arm/boot/dts/omap34xx.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/arch/arm/boot/dts/omap34xx.dtsi b/arch/arm/boot/dts/omap34xx.dtsi
> > >index 5cdba1f..e446562 100644
> > >--- a/arch/arm/boot/dts/omap34xx.dtsi
> > >+++ b/arch/arm/boot/dts/omap34xx.dtsi
> > >@@ -46,7 +46,7 @@
> > > 0x480bd800 0x017c>;
> > > interrupts = <24>;
> > > iommus = <&mmu_isp>;
> > >- syscon = <&scm_conf 0xdc>;
> > >+ syscon = <&scm_conf 0x6c>;
> > > ti,phy-type = <OMAP3ISP_PHY_TYPE_COMPLEX_IO>;
> > > #clock-cells = <1>;
> > > ports {
> > >
>
> You may want to add the hint, that 0xdc (the old, wrong "offset")
> represents the last few bits of the register address. I guess
> somebody didn't notice, that scm_conf does not start at a register
> address ending with 00 (like most other modules).
>
> Reviewed-By: Sebastian Reichel <sre@kernel.org>
Applying into omap-for-v4.6/fixes-rc5 thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-26 17:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-16 6:20 [PATCH] ARM: dts: omap3: Fix ISP syscon register offset Ivaylo Dimitrov
2016-04-22 4:34 ` Ivaylo Dimitrov
2016-04-22 13:16 ` Sebastian Reichel
2016-04-26 17:12 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).