From: andrew-ct.chen@mediatek.com (andrew-ct chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] VPU: mediatek: fix simple_open.cocci warnings
Date: Mon, 25 Apr 2016 20:42:51 +0800 [thread overview]
Message-ID: <1461588171.15167.10.camel@mtksdaap41> (raw)
In-Reply-To: <alpine.DEB.2.10.1604221509350.2872@hadrien>
On Fri, 2016-04-22 at 15:12 +0200, Julia Lawall wrote:
> Remove an open coded simple_open() function
> and replace file operations references to the function
> with simple_open() instead.
>
> Generated by: scripts/coccinelle/api/simple_open.cocci
>
> CC: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
Acked-by: Andrew-CT Chen <andrew-ct.chen@mediatek.com>
>
> I'm just passing this along. Simple_open additionally has a check that
> inode->i_private is not NULL, before doing the assignment. I don't know
> if that difference is important in this case.
>
> base: git://linuxtv.org/media_tree.git master
>
> mtk_vpu.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> --- a/drivers/media/platform/mtk-vpu/mtk_vpu.c
> +++ b/drivers/media/platform/mtk-vpu/mtk_vpu.c
> @@ -599,11 +599,6 @@ static void vpu_init_ipi_handler(void *d
> }
>
> #ifdef CONFIG_DEBUG_FS
> -static int vpu_debug_open(struct inode *inode, struct file *file)
> -{
> - file->private_data = inode->i_private;
> - return 0;
> -}
>
> static ssize_t vpu_debug_read(struct file *file, char __user *user_buf,
> size_t count, loff_t *ppos)
> @@ -646,7 +641,7 @@ static ssize_t vpu_debug_read(struct fil
> }
>
> static const struct file_operations vpu_debug_fops = {
> - .open = vpu_debug_open,
> + .open = simple_open,
> .read = vpu_debug_read,
> };
> #endif /* CONFIG_DEBUG_FS */
prev parent reply other threads:[~2016-04-25 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:12 [PATCH] VPU: mediatek: fix simple_open.cocci warnings Julia Lawall
2016-04-25 12:42 ` andrew-ct chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461588171.15167.10.camel@mtksdaap41 \
--to=andrew-ct.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox