linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sricharan@codeaurora.org (Sricharan R)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 9/9] drivers: iommu: arm-smmu: Set iommu_ops in probe
Date: Mon, 25 Apr 2016 21:28:14 +0530	[thread overview]
Message-ID: <1461599894-1969-10-git-send-email-sricharan@codeaurora.org> (raw)
In-Reply-To: <1461599894-1969-1-git-send-email-sricharan@codeaurora.org>

iommu_ops should be set after the iommu is probed.
This ensures that the iommu is really ready when master's
iommu ops are set during their probe or else deferred.

Signed-off-by: Sricharan R <sricharan@codeaurora.org>
---
 drivers/iommu/arm-smmu.c | 34 ++--------------------------------
 1 file changed, 2 insertions(+), 32 deletions(-)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index 2d65de4..f103d35 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -1919,6 +1919,7 @@ static int arm_smmu_device_dt_probe(struct platform_device *pdev)
 	if (of_property_read_bool(dev->of_node, "mmu-masters"))
 		arm_smmu_probe_mmu_masters(smmu);
 	arm_smmu_device_reset(smmu);
+	of_iommu_set_ops(dev->of_node, &arm_smmu_ops);
 	return 0;
 
 out_free_irqs:
@@ -1957,24 +1958,13 @@ static struct platform_driver arm_smmu_driver = {
 	.remove	= arm_smmu_device_remove,
 };
 
-static int __init arm_smmu_init(void)
+static int __init arm_smmu_of_init(struct device_node *np)
 {
-	struct device_node *np;
 	static bool done;
 	int ret;
 
 	if (done)
 		return 0;
-	/*
-	 * Play nice with systems that don't have an ARM SMMU by checking that
-	 * an ARM SMMU exists in the system before proceeding with the driver
-	 * and IOMMU bus operation registration.
-	 */
-	np = of_find_matching_node(NULL, arm_smmu_of_match);
-	if (!np)
-		return 0;
-
-	of_node_put(np);
 
 	ret = platform_driver_register(&arm_smmu_driver);
 	if (ret)
@@ -2002,28 +1992,8 @@ static void __exit arm_smmu_exit(void)
 {
 	return platform_driver_unregister(&arm_smmu_driver);
 }
-
-subsys_initcall(arm_smmu_init);
 module_exit(arm_smmu_exit);
 
-static int __init arm_smmu_of_init(struct device_node *np)
-{
-	struct arm_smmu_device *smmu;
-	struct platform_device *pdev;
-	int ret = arm_smmu_init();
-
-	if (ret)
-		return ret;
-
-	pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
-	if (!pdev)
-		return -ENODEV;
-
-	smmu = platform_get_drvdata(pdev);
-	of_iommu_set_ops(np, &arm_smmu_ops);
-
-	return 0;
-}
 IOMMU_OF_DECLARE(arm_smmuv1, "arm,smmu-v1", arm_smmu_of_init);
 IOMMU_OF_DECLARE(arm_smmuv2, "arm,smmu-v2", arm_smmu_of_init);
 IOMMU_OF_DECLARE(arm_mmu400, "arm,mmu-400", arm_smmu_of_init);
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2016-04-25 15:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-25 15:58 [RFC 0/9] IOMMU probe deferral support Sricharan R
2016-04-25 15:58 ` [RFC 1/9] arm: dma-mapping: Don't override dma_ops in arch_setup_dma_ops() Sricharan R
2016-04-25 15:58 ` [RFC 2/9] of: dma: Move range size workaround to of_dma_get_range() Sricharan R
2016-04-25 15:58 ` [RFC 3/9] of: dma: Make of_dma_deconfigure() public Sricharan R
2016-04-25 15:58 ` [RFC 4/9] of: dma: Split of_configure_dma() into mask and ops configuration Sricharan R
2016-04-25 15:58 ` [RFC 5/9] drivers: platform: Configure dma operations at probe time Sricharan R
2016-05-24 15:45   ` Robin Murphy
2016-05-26  4:03     ` Sricharan
2016-04-25 15:58 ` [RFC 6/9] iommu: of: Handle IOMMU lookup failure with deferred probing or error Sricharan R
2016-04-25 15:58 ` [RFC 7/9] drivers: iommu: Add a new add device api Sricharan R
2016-04-25 15:58 ` [RFC 8/9] drivers: of: call iommu_bus_add_dev after iommu_configure_ops Sricharan R
2016-05-23  8:37   ` Marek Szyprowski
2016-05-23  8:47     ` Sricharan
2016-05-24 15:59   ` Robin Murphy
2016-05-26  5:56     ` Sricharan
2016-04-25 15:58 ` Sricharan R [this message]
2016-05-12 12:52 ` [RFC 0/9] IOMMU probe deferral support Marek Szyprowski
2016-05-13  6:53   ` Sricharan
2016-05-20 11:34   ` Sricharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461599894-1969-10-git-send-email-sricharan@codeaurora.org \
    --to=sricharan@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).