linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] memory: mtk-smi: export mtk_smi_larb_get/put
Date: Wed, 27 Apr 2016 17:05:07 +0200	[thread overview]
Message-ID: <1461769507.4044.50.camel@pengutronix.de> (raw)
In-Reply-To: <5720BAF6.1070808@gmail.com>

Am Mittwoch, den 27.04.2016, 15:13 +0200 schrieb Matthias Brugger:
> 
> On 27/04/16 14:22, Philipp Zabel wrote:
> > Hi Matthias,
> >
> > Am Mittwoch, den 27.04.2016, 13:09 +0200 schrieb Matthias Brugger:
> >> Hi Philipp,
> >>
> >> On 27/04/16 10:51, Philipp Zabel wrote:
> >>> To allow building mediatek-drm.ko as a module, the
> >>> mtk_smi_larb_get and mtk_smi_larb_put symbols have
> >>> to be exported.
> >>>
> >>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> >>> ---
> >>>    drivers/memory/mtk-smi.c | 2 ++
> >>>    1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
> >>> index 089091f..f6b5757 100644
> >>> --- a/drivers/memory/mtk-smi.c
> >>> +++ b/drivers/memory/mtk-smi.c
> >>> @@ -91,6 +91,7 @@ int mtk_smi_larb_get(struct device *larbdev)
> >>>
> >>>    	return 0;
> >>>    }
> >>> +EXPORT_SYMBOL_GPL(mtk_smi_larb_get);
> >>>
> >>>    void mtk_smi_larb_put(struct device *larbdev)
> >>>    {
> >>> @@ -106,6 +107,7 @@ void mtk_smi_larb_put(struct device *larbdev)
> >>>    	mtk_smi_disable(&larb->smi);
> >>>    	mtk_smi_disable(common);
> >>>    }
> >>> +EXPORT_SYMBOL_GPL(mtk_smi_larb_put);
> >>>
> >>>    static int
> >>>    mtk_smi_larb_bind(struct device *dev, struct device *master, void *data)
> >>>
> >>
> >> Strangely this didn't work with my config (attached).
> >> Would you mind to double check?
> >
> > warning: (DRM_MEDIATEK && MTK_IOMMU) selects MTK_SMI which has unmet
> > direct dependencies (MEMORY && (ARCH_MEDIATEK || COMPILE_TEST))
> >
> > I suppose DRM_MEDIATEK also has to select MEMORY, just like MTK_IOMMU
> > does?
> >
> 
> Yes that's it.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> Dave, can you take this patch through your tree to avoid build breakage?
> 
> Thanks,
> Matthias

Should I include this patch in the next MT8173 DRM pull request?

regards
Philipp

  reply	other threads:[~2016-04-27 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  8:51 [PATCH] memory: mtk-smi: export mtk_smi_larb_get/put Philipp Zabel
2016-04-27 11:09 ` Matthias Brugger
2016-04-27 12:22   ` Philipp Zabel
2016-04-27 13:13     ` Matthias Brugger
2016-04-27 15:05       ` Philipp Zabel [this message]
2016-04-29  5:08         ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461769507.4044.50.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).