* [PATCH] of: include errno.h in of_graph.h
@ 2016-05-02 10:59 Arnd Bergmann
2016-05-02 14:00 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-05-02 10:59 UTC (permalink / raw)
To: linux-arm-kernel
When CONFIG_OF is disabled, we have to include linux/errno.h before
including of_graph.h, or get build errors like in the newly added
sun4i drm driver:
In file included from ../drivers/gpu/drm/sun4i/sun4i_drv.c:14:0:
include/linux/of_graph.h: In function 'of_graph_parse_endpoint':
include/linux/of_graph.h:58:10: error: 'ENOSYS' undeclared (first use in this function)
A better solution is to ensure that the header can be included
by itself, so let's include linux/errno.h here to fix the error
we just got, and any similar future error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
---
include/linux/of_graph.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
index f8bcd0e21a26..bb3a5a2cd570 100644
--- a/include/linux/of_graph.h
+++ b/include/linux/of_graph.h
@@ -15,6 +15,7 @@
#define __LINUX_OF_GRAPH_H
#include <linux/types.h>
+#include <linux/errno.h>
/**
* struct of_endpoint - the OF graph endpoint data structure
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] of: include errno.h in of_graph.h
2016-05-02 10:59 [PATCH] of: include errno.h in of_graph.h Arnd Bergmann
@ 2016-05-02 14:00 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-05-02 14:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 02, 2016 at 12:59:19PM +0200, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we have to include linux/errno.h before
> including of_graph.h, or get build errors like in the newly added
> sun4i drm driver:
>
> In file included from ../drivers/gpu/drm/sun4i/sun4i_drv.c:14:0:
> include/linux/of_graph.h: In function 'of_graph_parse_endpoint':
> include/linux/of_graph.h:58:10: error: 'ENOSYS' undeclared (first use in this function)
>
> A better solution is to ensure that the header can be included
> by itself, so let's include linux/errno.h here to fix the error
> we just got, and any similar future error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> ---
> include/linux/of_graph.h | 1 +
> 1 file changed, 1 insertion(+)
Applied.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-02 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-02 10:59 [PATCH] of: include errno.h in of_graph.h Arnd Bergmann
2016-05-02 14:00 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).