[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[Alexander Müller]

Fixes a bad bit index in preparation for ethernet support on ODROID-C1.

Alexander M?ller (1):
  pinctrl: meson: Fix eth_tx_en bit index

 drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.5.0

[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[Alexander Müller]

Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet.

Signed-off-by: Alexander M?ller <serveralex@gmail.com>
---
 drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c
index a100bcf..874f2ed 100644
--- a/drivers/pinctrl/meson/pinctrl-meson8b.c
+++ b/drivers/pinctrl/meson/pinctrl-meson8b.c
@@ -564,7 +564,7 @@ static struct meson_pmx_group meson8b_cbus_groups[] = {
 	GROUP(eth_rx_clk,	6,	3),
 	GROUP(eth_txd0_1,	6,	4),
 	GROUP(eth_txd1_1,	6,	5),
-	GROUP(eth_tx_en,	6,	0),
+	GROUP(eth_tx_en,	6,	6),
 	GROUP(eth_ref_clk,	6,	8),
 	GROUP(eth_mdc,		6,	9),
 	GROUP(eth_mdio_en,	6,	10),
-- 
2.5.0

[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[Linus Walleij]

On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote:

> Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet.
>
> Signed-off-by: Alexander M?ller <serveralex@gmail.com>

Carlo can you review this change?

Yours,
Linus Walleij

[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[Carlo Caione]

On Wed, May 11, 2016 at 10:58 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote:
>
>> Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet.
>>
>> Signed-off-by: Alexander M?ller <serveralex@gmail.com>
>
> Carlo can you review this change?

Acked-by: Carlo Caione <carlo@endlessm.com>

just to let you know this patch has been posted also as part of a
bigger patchset here
http://permalink.gmane.org/gmane.linux.ports.arm.kernel/498960

-- 
Carlo Caione

[PATCH] pinctrl: meson: Fix eth_tx_en bit index

[Linus Walleij]

On Wed, May 11, 2016 at 11:13 AM, Carlo Caione <carlo@caione.org> wrote:
> On Wed, May 11, 2016 at 10:58 AM, Linus Walleij
> <linus.walleij@linaro.org> wrote:
>> On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote:
>>
>>> Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet.
>>>
>>> Signed-off-by: Alexander M?ller <serveralex@gmail.com>
>>
>> Carlo can you review this change?
>
> Acked-by: Carlo Caione <carlo@endlessm.com>

Thanks, patch applied with your ACK.

> just to let you know this patch has been posted also as part of a
> bigger patchset here
> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/498960

Yeah I saw. But it seemed like an orthogonal fix so I better just
merge it now into the pin control tree.

Yours,
Linus Walleij