* [PATCH] pinctrl: meson: Fix eth_tx_en bit index @ 2016-05-08 17:59 Alexander Müller 2016-05-08 17:59 ` Alexander Müller 0 siblings, 1 reply; 5+ messages in thread From: Alexander Müller @ 2016-05-08 17:59 UTC (permalink / raw) To: linux-arm-kernel Fixes a bad bit index in preparation for ethernet support on ODROID-C1. Alexander M?ller (1): pinctrl: meson: Fix eth_tx_en bit index drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.5.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: meson: Fix eth_tx_en bit index 2016-05-08 17:59 [PATCH] pinctrl: meson: Fix eth_tx_en bit index Alexander Müller @ 2016-05-08 17:59 ` Alexander Müller 2016-05-11 8:58 ` Linus Walleij 0 siblings, 1 reply; 5+ messages in thread From: Alexander Müller @ 2016-05-08 17:59 UTC (permalink / raw) To: linux-arm-kernel Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet. Signed-off-by: Alexander M?ller <serveralex@gmail.com> --- drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c index a100bcf..874f2ed 100644 --- a/drivers/pinctrl/meson/pinctrl-meson8b.c +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c @@ -564,7 +564,7 @@ static struct meson_pmx_group meson8b_cbus_groups[] = { GROUP(eth_rx_clk, 6, 3), GROUP(eth_txd0_1, 6, 4), GROUP(eth_txd1_1, 6, 5), - GROUP(eth_tx_en, 6, 0), + GROUP(eth_tx_en, 6, 6), GROUP(eth_ref_clk, 6, 8), GROUP(eth_mdc, 6, 9), GROUP(eth_mdio_en, 6, 10), -- 2.5.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: meson: Fix eth_tx_en bit index 2016-05-08 17:59 ` Alexander Müller @ 2016-05-11 8:58 ` Linus Walleij 2016-05-11 9:13 ` Carlo Caione 0 siblings, 1 reply; 5+ messages in thread From: Linus Walleij @ 2016-05-11 8:58 UTC (permalink / raw) To: linux-arm-kernel On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote: > Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet. > > Signed-off-by: Alexander M?ller <serveralex@gmail.com> Carlo can you review this change? Yours, Linus Walleij ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: meson: Fix eth_tx_en bit index 2016-05-11 8:58 ` Linus Walleij @ 2016-05-11 9:13 ` Carlo Caione 2016-05-11 12:19 ` Linus Walleij 0 siblings, 1 reply; 5+ messages in thread From: Carlo Caione @ 2016-05-11 9:13 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 11, 2016 at 10:58 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote: > >> Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet. >> >> Signed-off-by: Alexander M?ller <serveralex@gmail.com> > > Carlo can you review this change? Acked-by: Carlo Caione <carlo@endlessm.com> just to let you know this patch has been posted also as part of a bigger patchset here http://permalink.gmane.org/gmane.linux.ports.arm.kernel/498960 -- Carlo Caione ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pinctrl: meson: Fix eth_tx_en bit index 2016-05-11 9:13 ` Carlo Caione @ 2016-05-11 12:19 ` Linus Walleij 0 siblings, 0 replies; 5+ messages in thread From: Linus Walleij @ 2016-05-11 12:19 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 11, 2016 at 11:13 AM, Carlo Caione <carlo@caione.org> wrote: > On Wed, May 11, 2016 at 10:58 AM, Linus Walleij > <linus.walleij@linaro.org> wrote: >> On Sun, May 8, 2016 at 7:59 PM, Alexander M?ller <serveralex@gmail.com> wrote: >> >>> Fix pinctrl eth_tx_en bit index according to Hardkernel ODROID-C1 datasheet. >>> >>> Signed-off-by: Alexander M?ller <serveralex@gmail.com> >> >> Carlo can you review this change? > > Acked-by: Carlo Caione <carlo@endlessm.com> Thanks, patch applied with your ACK. > just to let you know this patch has been posted also as part of a > bigger patchset here > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/498960 Yeah I saw. But it seemed like an orthogonal fix so I better just merge it now into the pin control tree. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-11 12:19 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-08 17:59 [PATCH] pinctrl: meson: Fix eth_tx_en bit index Alexander Müller 2016-05-08 17:59 ` Alexander Müller 2016-05-11 8:58 ` Linus Walleij 2016-05-11 9:13 ` Carlo Caione 2016-05-11 12:19 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).