From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Wed, 11 May 2016 12:34:13 +0200 Subject: [RFC PATCH 13/21] reset: uniphier: add reset driver for UniPhier PH1-LD4 SoC In-Reply-To: References: <1462873862-30940-1-git-send-email-yamada.masahiro@socionext.com> <1462873862-30940-14-git-send-email-yamada.masahiro@socionext.com> <1462883138.9155.3.camel@pengutronix.de> Message-ID: <1462962853.2924.19.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Masahiro, Am Mittwoch, den 11.05.2016, 11:52 +0900 schrieb Masahiro Yamada: > Hi Philipp, > > > 2016-05-10 21:25 GMT+09:00 Philipp Zabel : > > Hi Masahiro, > > > > Am Dienstag, den 10.05.2016, 18:50 +0900 schrieb Masahiro Yamada: > >> This series is just for review. > >> Please do not apply this patch. > >> > >> Signed-off-by: Masahiro Yamada > > > > No need for all these tiny drivers. If you probe from DT as Lee > > requests, you can let of_device_id.data point to a compatible specific > > uniphier_reset_data. > > > > I will need to fill the table a bit more to complete this work, > but I do not think this reset driver will become as big as the clk driver. > (I guess it will be less than 1000 lines.) > > If you prefer a single file for the whole of this SoC family, > I can squash all the files into one. > (I can split it if I need to do so in the future.) I'm fine with split files if you think the complete lists are too long, but in that case export the uniphier_reset_data I don't care about the lists being in a single file so much as I'd prefer to avoid the duplicated boilerplate of one module_platform_driver per SoC family member. > > >