* [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default
@ 2016-05-14 17:57 Hans de Goede
2016-05-14 17:57 ` [PATCH 2/4] ARM: dts: axp22x.dtsi: Add usb_power_supply node Hans de Goede
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Hans de Goede @ 2016-05-14 17:57 UTC (permalink / raw)
To: linux-arm-kernel
Use of these as regulators conflicts with use of the gpio pins as
gpios, so disabled the ldo_io# regulators by default, this avoids
the regulator core touching them when the pins are used as gpios.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
arch/arm/boot/dts/axp22x.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
index 76302f5..0cfec50 100644
--- a/arch/arm/boot/dts/axp22x.dtsi
+++ b/arch/arm/boot/dts/axp22x.dtsi
@@ -126,10 +126,12 @@
reg_ldo_io0: ldo_io0 {
regulator-name = "ldo_io0";
+ status = "disabled";
};
reg_ldo_io1: ldo_io1 {
regulator-name = "ldo_io1";
+ status = "disabled";
};
reg_rtc_ldo: rtc_ldo {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/4] ARM: dts: axp22x.dtsi: Add usb_power_supply node 2016-05-14 17:57 [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Hans de Goede @ 2016-05-14 17:57 ` Hans de Goede 2016-05-14 17:57 ` [PATCH 3/4] ARM: dts: axp22x.dtsi: Add reg_drivebus node Hans de Goede ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: Hans de Goede @ 2016-05-14 17:57 UTC (permalink / raw) To: linux-arm-kernel Add a node describing the (optional) usbpower-supply of the axp221 / axp223 pmic. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/axp22x.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi index 0cfec50..cbafca6 100644 --- a/arch/arm/boot/dts/axp22x.dtsi +++ b/arch/arm/boot/dts/axp22x.dtsi @@ -142,4 +142,9 @@ regulator-name = "rtc_ldo"; }; }; + + usb_power_supply: usb_power_supply { + compatible = "x-powers,axp202-usb-power-supply"; + status = "disabled"; + }; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/4] ARM: dts: axp22x.dtsi: Add reg_drivebus node 2016-05-14 17:57 [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Hans de Goede 2016-05-14 17:57 ` [PATCH 2/4] ARM: dts: axp22x.dtsi: Add usb_power_supply node Hans de Goede @ 2016-05-14 17:57 ` Hans de Goede 2016-05-14 17:57 ` [PATCH 4/4] ARM: dts: sun8i-a?3-q8-tablet.dts: Add full otg support Hans de Goede 2016-05-17 8:50 ` [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Chen-Yu Tsai 3 siblings, 0 replies; 5+ messages in thread From: Hans de Goede @ 2016-05-14 17:57 UTC (permalink / raw) To: linux-arm-kernel Add a node describing the drivebus regulator which is an (optional) part of the axp221/axp223 pmic. Since this regulator may not be available at all depending on the board, mark it as disabled by default. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/axp22x.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi index cbafca6..6903d471 100644 --- a/arch/arm/boot/dts/axp22x.dtsi +++ b/arch/arm/boot/dts/axp22x.dtsi @@ -141,6 +141,11 @@ regulator-max-microvolt = <3000000>; regulator-name = "rtc_ldo"; }; + + reg_drivebus: drivebus { + regulator-name = "drivebus"; + status = "disabled"; + }; }; usb_power_supply: usb_power_supply { -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 4/4] ARM: dts: sun8i-a?3-q8-tablet.dts: Add full otg support 2016-05-14 17:57 [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Hans de Goede 2016-05-14 17:57 ` [PATCH 2/4] ARM: dts: axp22x.dtsi: Add usb_power_supply node Hans de Goede 2016-05-14 17:57 ` [PATCH 3/4] ARM: dts: axp22x.dtsi: Add reg_drivebus node Hans de Goede @ 2016-05-14 17:57 ` Hans de Goede 2016-05-17 8:50 ` [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Chen-Yu Tsai 3 siblings, 0 replies; 5+ messages in thread From: Hans de Goede @ 2016-05-14 17:57 UTC (permalink / raw) To: linux-arm-kernel Now that we've all the necessary bits in place we can enable full otg support on these tablets. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- arch/arm/boot/dts/sun8i-a23-q8-tablet.dts | 15 --------------- arch/arm/boot/dts/sun8i-a33-q8-tablet.dts | 15 --------------- arch/arm/boot/dts/sun8i-q8-common.dtsi | 31 +++++++++++++++++++++++++++++++ 3 files changed, 31 insertions(+), 30 deletions(-) diff --git a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts index 6062ea7..956320a 100644 --- a/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts +++ b/arch/arm/boot/dts/sun8i-a23-q8-tablet.dts @@ -48,18 +48,3 @@ model = "Q8 A23 Tablet"; compatible = "allwinner,q8-a23", "allwinner,sun8i-a23"; }; - -/* - * FIXME for now we only support host mode and rely on u-boot to have - * turned on Vbus which is controlled by the axp223 pmic on the board. - * - * Once we have axp223 support we should switch to fully supporting otg. - */ -&usb_otg { - dr_mode = "host"; - status = "okay"; -}; - -&usbphy { - status = "okay"; -}; diff --git a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts index 44b3229..b0bc236 100644 --- a/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts +++ b/arch/arm/boot/dts/sun8i-a33-q8-tablet.dts @@ -48,18 +48,3 @@ model = "Q8 A33 Tablet"; compatible = "allwinner,q8-a33", "allwinner,sun8i-a33"; }; - -/* - * FIXME for now we only support host mode and rely on u-boot to have - * turned on Vbus which is controlled by the axp223 pmic on the board. - * - * Once we have axp223 support we should switch to fully supporting otg. - */ -&usb_otg { - dr_mode = "host"; - status = "okay"; -}; - -&usbphy { - status = "okay"; -}; diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi index 346a49d..2e2cbf5 100644 --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi @@ -87,6 +87,13 @@ allwinner,drive = <SUN4I_PINCTRL_10_MA>; allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; }; + + usb0_id_detect_pin: usb0_id_detect_pin at 0 { + allwinner,pins = "PH8"; + allwinner,function = "gpio_in"; + allwinner,drive = <SUN4I_PINCTRL_10_MA>; + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>; + }; }; &r_rsb { @@ -98,6 +105,7 @@ interrupt-parent = <&nmi_intc>; interrupts = <0 IRQ_TYPE_LEVEL_LOW>; eldoin-supply = <®_dcdc1>; + x-powers,drivebus; }; }; @@ -163,6 +171,11 @@ regulator-name = "vcc-dram"; }; +®_drivebus { + regulator-name = "usb0-vbus"; + status = "okay"; +}; + ®_rtc_ldo { regulator-name = "vcc-rtc"; }; @@ -176,3 +189,21 @@ &simplefb_lcd { vcc-lcd-supply = <®_dc1sw>; }; + +&usb_otg { + dr_mode = "otg"; + status = "okay"; +}; + +&usb_power_supply { + status = "okay"; +}; + +&usbphy { + pinctrl-names = "default"; + pinctrl-0 = <&usb0_id_detect_pin>; + usb0_id_det-gpio = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ + usb0_vbus_power-supply = <&usb_power_supply>; + usb0_vbus-supply = <®_drivebus>; + status = "okay"; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default 2016-05-14 17:57 [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Hans de Goede ` (2 preceding siblings ...) 2016-05-14 17:57 ` [PATCH 4/4] ARM: dts: sun8i-a?3-q8-tablet.dts: Add full otg support Hans de Goede @ 2016-05-17 8:50 ` Chen-Yu Tsai 3 siblings, 0 replies; 5+ messages in thread From: Chen-Yu Tsai @ 2016-05-17 8:50 UTC (permalink / raw) To: linux-arm-kernel On Sun, May 15, 2016 at 1:57 AM, Hans de Goede <hdegoede@redhat.com> wrote: > Use of these as regulators conflicts with use of the gpio pins as > gpios, so disabled the ldo_io# regulators by default, this avoids > the regulator core touching them when the pins are used as gpios. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Chen-Yu Tsai <wens@csie.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-17 8:50 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-14 17:57 [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Hans de Goede 2016-05-14 17:57 ` [PATCH 2/4] ARM: dts: axp22x.dtsi: Add usb_power_supply node Hans de Goede 2016-05-14 17:57 ` [PATCH 3/4] ARM: dts: axp22x.dtsi: Add reg_drivebus node Hans de Goede 2016-05-14 17:57 ` [PATCH 4/4] ARM: dts: sun8i-a?3-q8-tablet.dts: Add full otg support Hans de Goede 2016-05-17 8:50 ` [PATCH 1/4] ARM: dts: axp22x.dtsi: Disable axp22x ldo_io# regulators by default Chen-Yu Tsai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).