linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sudipm.mukherjee@gmail.com (Sudip Mukherjee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] hwrng: stm32 - fix build warning
Date: Mon, 23 May 2016 18:14:08 +0530	[thread overview]
Message-ID: <1464007448-25395-1-git-send-email-sudipm.mukherjee@gmail.com> (raw)

We have been getting build warning about:
drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read':
drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used
					uninitialized in this function

On checking the code it turns out that sr can never be used
uninitialized as sr is getting initialized in the while loop and while
loop will always execute as the minimum value of max can be 32.
So just initialize sr to 0 while declaring it to silence the compiler.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

build log at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/132180906

 drivers/char/hw_random/stm32-rng.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c
index 92a8106..0533370 100644
--- a/drivers/char/hw_random/stm32-rng.c
+++ b/drivers/char/hw_random/stm32-rng.c
@@ -52,7 +52,7 @@ static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool wait)
 {
 	struct stm32_rng_private *priv =
 	    container_of(rng, struct stm32_rng_private, rng);
-	u32 sr;
+	u32 sr = 0;
 	int retval = 0;
 
 	pm_runtime_get_sync((struct device *) priv->rng.priv);
-- 
1.9.1

             reply	other threads:[~2016-05-23 12:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 12:44 Sudip Mukherjee [this message]
2016-05-23 20:35 ` [PATCH] hwrng: stm32 - fix build warning Arnd Bergmann
2016-05-24  7:59   ` Maxime Coquelin
2016-05-24  8:32     ` Arnd Bergmann
2016-05-24  8:50       ` Maxime Coquelin
2016-05-24  8:58         ` Arnd Bergmann
2016-05-24  9:20           ` Maxime Coquelin
2016-05-25  2:00             ` Sudip Mukherjee
2016-05-24 10:09         ` Daniel Thompson
2016-05-24 10:57           ` Maxime Coquelin
2016-05-25  2:05   ` Sudip Mukherjee
2016-05-25 10:06     ` Arnd Bergmann
2016-05-27  9:00       ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464007448-25395-1-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).