From: wangkefeng.wang@huawei.com (Kefeng Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] of_numa: Use of_get_next_parent to simplify code
Date: Thu, 2 Jun 2016 14:03:07 +0800 [thread overview]
Message-ID: <1464847389-11652-2-git-send-email-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <1464847389-11652-1-git-send-email-wangkefeng.wang@huawei.com>
Use of_get_next_parent() instead of open-code.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/of/of_numa.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
index 3157130..ed7bd22 100644
--- a/drivers/of/of_numa.c
+++ b/drivers/of/of_numa.c
@@ -153,8 +153,6 @@ int of_node_to_nid(struct device_node *device)
np = of_node_get(device);
while (np) {
- struct device_node *parent;
-
r = of_property_read_u32(np, "numa-node-id", &nid);
/*
* -EINVAL indicates the property was not found, and
@@ -165,9 +163,7 @@ int of_node_to_nid(struct device_node *device)
if (r != -EINVAL)
break;
- parent = of_get_parent(np);
- of_node_put(np);
- np = parent;
+ np = of_get_next_parent(np);
}
if (np && r)
pr_warn("NUMA: Invalid \"numa-node-id\" property in node %s\n",
--
1.7.12.4
next prev parent reply other threads:[~2016-06-02 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 2:28 [PATCH v3 0/5] fix some type infos and bugs for arm64/of numa Zhen Lei
2016-06-02 2:28 ` [PATCH v3 1/5] of/numa: remove a duplicated pr_debug information Zhen Lei
2016-06-02 2:28 ` [PATCH v3 2/5] of/numa: fix a memory@ node can only contains one memory block Zhen Lei
2016-06-02 2:28 ` [PATCH v3 3/5] arm64/numa: add nid check for " Zhen Lei
2016-06-03 9:52 ` Will Deacon
2016-06-06 1:43 ` Leizhen (ThunderTown)
2016-06-02 2:28 ` [PATCH v3 4/5] of/numa: remove a duplicated warning Zhen Lei
2016-06-02 2:28 ` [PATCH v3 5/5] arm64/numa: avoid inconsistent information to be printed Zhen Lei
2016-06-03 9:55 ` Will Deacon
2016-06-06 2:04 ` Leizhen (ThunderTown)
2016-06-02 6:03 ` [PATCH 0/3] of: numa: cleanup Kefeng Wang
2016-06-02 6:03 ` Kefeng Wang [this message]
2016-06-02 6:03 ` [PATCH 2/3] of_numa: Use pr_fmt() Kefeng Wang
2016-06-02 6:03 ` [PATCH 3/3] arm64: numa: " Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464847389-11652-2-git-send-email-wangkefeng.wang@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).