* [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem
@ 2016-06-07 12:24 Ben Dooks
2016-06-10 15:49 ` Thierry Reding
2016-06-13 0:54 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2016-06-07 12:24 UTC (permalink / raw)
To: linux-arm-kernel
Fix the following warnings from sparse due to casting to/from __iomem
annotated variables:
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
drivers/irqchip/irq-tegra.c:269:57: warning: incorrect type in argument 5 (different address spaces)
drivers/irqchip/irq-tegra.c:269:57: expected void *chip_data
drivers/irqchip/irq-tegra.c:269:57: got void [noderef] <asn:2>*<noident>
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-kernel at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: linux-tegra at vger.kernel.org
---
drivers/irqchip/irq-tegra.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index e902f08..3973a14 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -90,7 +90,7 @@ static struct tegra_ictlr_info *lic;
static inline void tegra_ictlr_write_mask(struct irq_data *d, unsigned long reg)
{
- void __iomem *base = d->chip_data;
+ void __iomem *base = (void __iomem __force *)d->chip_data;
u32 mask;
mask = BIT(d->hwirq % 32);
@@ -266,7 +266,7 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
irq_domain_set_hwirq_and_chip(domain, virq + i, hwirq + i,
&tegra_ictlr_chip,
- info->base[ictlr]);
+ (void __force *)info->base[ictlr]);
}
parent_fwspec = *fwspec;
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem
2016-06-07 12:24 [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem Ben Dooks
@ 2016-06-10 15:49 ` Thierry Reding
2016-06-13 0:54 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2016-06-10 15:49 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jun 07, 2016 at 01:24:52PM +0100, Ben Dooks wrote:
> Fix the following warnings from sparse due to casting to/from __iomem
> annotated variables:
>
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:269:57: warning: incorrect type in argument 5 (different address spaces)
> drivers/irqchip/irq-tegra.c:269:57: expected void *chip_data
> drivers/irqchip/irq-tegra.c:269:57: got void [noderef] <asn:2>*<noident>
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: linux-kernel at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-tegra at vger.kernel.org
> ---
> drivers/irqchip/irq-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/eeb4edfa/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem
2016-06-07 12:24 [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem Ben Dooks
2016-06-10 15:49 ` Thierry Reding
@ 2016-06-13 0:54 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2016-06-13 0:54 UTC (permalink / raw)
To: linux-arm-kernel
Hi Ben,
On Tue, Jun 07, 2016 at 01:24:52PM +0100, Ben Dooks wrote:
> Fix the following warnings from sparse due to casting to/from __iomem
> annotated variables:
>
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:93:31: warning: incorrect type in initializer (different address spaces)
> drivers/irqchip/irq-tegra.c:93:31: expected void [noderef] <asn:2>*base
> drivers/irqchip/irq-tegra.c:93:31: got void *chip_data
> drivers/irqchip/irq-tegra.c:269:57: warning: incorrect type in argument 5 (different address spaces)
> drivers/irqchip/irq-tegra.c:269:57: expected void *chip_data
> drivers/irqchip/irq-tegra.c:269:57: got void [noderef] <asn:2>*<noident>
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: linux-kernel at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-tegra at vger.kernel.org
> ---
> drivers/irqchip/irq-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to irqchip/misc with Thierry's Ack.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-13 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 12:24 [PATCH] irqchip/tegra: fix fix sparse warnings on __iomem Ben Dooks
2016-06-10 15:49 ` Thierry Reding
2016-06-13 0:54 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).