From mboxrd@z Thu Jan  1 00:00:00 1970
From: joe@perches.com (Joe Perches)
Date: Tue, 07 Jun 2016 07:35:56 -0700
Subject: [PATCH v10 2/4] tee: generic TEE subsystem
In-Reply-To: <20160607105015.GA18132@ermac>
References: <1464784888-19854-1-git-send-email-jens.wiklander@linaro.org>
 <1464784888-19854-3-git-send-email-jens.wiklander@linaro.org>
 <5755EECA.6040606@ti.com> <20160607105015.GA18132@ermac>
Message-ID: <1465310156.25087.19.camel@perches.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, 2016-06-07 at 12:50 +0200, Jens Wiklander wrote:
> On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote:
> > 
> > On 06/01/2016 07:41 AM, Jens Wiklander wrote:
> > few minor comments below.
> > 
> > I see the patch generated (with --strict):
> > > 
> > > CHECK: Alignment should match open parenthesis
> > > #512: FILE: drivers/tee/tee.c:375:
> > > +static int tee_ioctl_close_session(struct tee_context *ctx,
> > > +??????????????struct tee_ioctl_close_session_arg __user *uarg)
> > > CHECK: Alignment should match open parenthesis
> > > #1607: FILE: drivers/tee/tee_shm_pool.c:103:
> > > +struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev,
> > > +??????????????????????struct tee_shm_pool_mem_info *priv_info,
> > > CHECK: Alignment should match open parenthesis
> The alternative is to format it as:
> struct tee_shm_pool *tee_shm_pool_alloc_res_mem(struct device *dev,
> ????????????????????????????????????????????????struct tee_shm_pool_mem_info
> ????????????????????????????????????????????????????????*priv_info,
> ????????????????????????????????????????????????struct tee_shm_pool_mem_info
> ????????????????????????????????????????????????????????*dmabuf_info)
> But that is a bit awkward. I'd like to keep it as it is if you don't mind.

another style uses a separate line for the return type

struct tee_shm_pool *
tee_shm_pool_alloc_res_mem(struct device *dev,
			? ?struct tee_shm_pool_mem_info *priv_info,
			? ?struct tee_shm_pool_mem_info *dmabuf_info)