* [PATCH] phy-sun4i-usb: fix missing __iomem *
@ 2016-06-07 17:14 Ben Dooks
2016-06-08 10:09 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2016-06-07 17:14 UTC (permalink / raw)
To: linux-arm-kernel
Fix the missing __iomem attribute in sun4i_usb_phy_write()
function. This fixes the following sparse warnings:
drivers/phy/phy-sun4i-usb.c:178:39: warning: incorrect type in initializer (different address spaces)
drivers/phy/phy-sun4i-usb.c:178:39: expected void *phyctl
drivers/phy/phy-sun4i-usb.c:178:39: got void [noderef] <asn:2>*
drivers/phy/phy-sun4i-usb.c:185:17: warning: incorrect type in argument 2 (different address spaces)
drivers/phy/phy-sun4i-usb.c:185:17: expected void volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:185:17: got void *phyctl
drivers/phy/phy-sun4i-usb.c:189:24: warning: incorrect type in argument 1 (different address spaces)
drivers/phy/phy-sun4i-usb.c:189:24: expected void const volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:189:24: got void *phyctl
drivers/phy/phy-sun4i-usb.c:196:17: warning: incorrect type in argument 2 (different address spaces)
drivers/phy/phy-sun4i-usb.c:196:17: expected void volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:196:17: got void *phyctl
drivers/phy/phy-sun4i-usb.c:199:24: warning: incorrect type in argument 1 (different address spaces)
drivers/phy/phy-sun4i-usb.c:199:24: expected void const volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:199:24: got void *phyctl
drivers/phy/phy-sun4i-usb.c:205:17: warning: incorrect type in argument 2 (different address spaces)
drivers/phy/phy-sun4i-usb.c:205:17: expected void volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:205:17: got void *phyctl
drivers/phy/phy-sun4i-usb.c:208:24: warning: incorrect type in argument 1 (different address spaces)
drivers/phy/phy-sun4i-usb.c:208:24: expected void const volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:208:24: got void *phyctl
drivers/phy/phy-sun4i-usb.c:210:17: warning: incorrect type in argument 2 (different address spaces)
drivers/phy/phy-sun4i-usb.c:210:17: expected void volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:210:17: got void *phyctl
drivers/phy/phy-sun4i-usb.c:212:24: warning: incorrect type in argument 1 (different address spaces)
drivers/phy/phy-sun4i-usb.c:212:24: expected void const volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:212:24: got void *phyctl
drivers/phy/phy-sun4i-usb.c:214:17: warning: incorrect type in argument 2 (different address spaces)
drivers/phy/phy-sun4i-usb.c:214:17: expected void volatile [noderef] <asn:2>*addr
drivers/phy/phy-sun4i-usb.c:214:17: got void *phyctl
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Chen-Yu Tsai <wens@csie.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/phy/phy-sun4i-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
index bae54f7..9de9991 100644
--- a/drivers/phy/phy-sun4i-usb.c
+++ b/drivers/phy/phy-sun4i-usb.c
@@ -175,7 +175,7 @@ static void sun4i_usb_phy_write(struct sun4i_usb_phy *phy, u32 addr, u32 data,
{
struct sun4i_usb_phy_data *phy_data = to_sun4i_usb_phy_data(phy);
u32 temp, usbc_bit = BIT(phy->index * 2);
- void *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
+ void __iomem *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
int i;
mutex_lock(&phy_data->mutex);
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] phy-sun4i-usb: fix missing __iomem *
2016-06-07 17:14 [PATCH] phy-sun4i-usb: fix missing __iomem * Ben Dooks
@ 2016-06-08 10:09 ` Hans de Goede
2016-06-17 13:25 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2016-06-08 10:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 07-06-16 19:14, Ben Dooks wrote:
> Fix the missing __iomem attribute in sun4i_usb_phy_write()
> function. This fixes the following sparse warnings:
>
> drivers/phy/phy-sun4i-usb.c:178:39: warning: incorrect type in initializer (different address spaces)
> drivers/phy/phy-sun4i-usb.c:178:39: expected void *phyctl
> drivers/phy/phy-sun4i-usb.c:178:39: got void [noderef] <asn:2>*
> drivers/phy/phy-sun4i-usb.c:185:17: warning: incorrect type in argument 2 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:185:17: expected void volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:185:17: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:189:24: warning: incorrect type in argument 1 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:189:24: expected void const volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:189:24: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:196:17: warning: incorrect type in argument 2 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:196:17: expected void volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:196:17: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:199:24: warning: incorrect type in argument 1 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:199:24: expected void const volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:199:24: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:205:17: warning: incorrect type in argument 2 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:205:17: expected void volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:205:17: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:208:24: warning: incorrect type in argument 1 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:208:24: expected void const volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:208:24: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:210:17: warning: incorrect type in argument 2 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:210:17: expected void volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:210:17: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:212:24: warning: incorrect type in argument 1 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:212:24: expected void const volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:212:24: got void *phyctl
> drivers/phy/phy-sun4i-usb.c:214:17: warning: incorrect type in argument 2 (different address spaces)
> drivers/phy/phy-sun4i-usb.c:214:17: expected void volatile [noderef] <asn:2>*addr
> drivers/phy/phy-sun4i-usb.c:214:17: got void *phyctl
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Thanks for catching this:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
> drivers/phy/phy-sun4i-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
> index bae54f7..9de9991 100644
> --- a/drivers/phy/phy-sun4i-usb.c
> +++ b/drivers/phy/phy-sun4i-usb.c
> @@ -175,7 +175,7 @@ static void sun4i_usb_phy_write(struct sun4i_usb_phy *phy, u32 addr, u32 data,
> {
> struct sun4i_usb_phy_data *phy_data = to_sun4i_usb_phy_data(phy);
> u32 temp, usbc_bit = BIT(phy->index * 2);
> - void *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
> + void __iomem *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
> int i;
>
> mutex_lock(&phy_data->mutex);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] phy-sun4i-usb: fix missing __iomem *
2016-06-08 10:09 ` Hans de Goede
@ 2016-06-17 13:25 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 3+ messages in thread
From: Kishon Vijay Abraham I @ 2016-06-17 13:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 08 June 2016 03:39 PM, Hans de Goede wrote:
> Hi,
>
> On 07-06-16 19:14, Ben Dooks wrote:
>> Fix the missing __iomem attribute in sun4i_usb_phy_write()
>> function. This fixes the following sparse warnings:
>>
>> drivers/phy/phy-sun4i-usb.c:178:39: warning: incorrect type in initializer
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:178:39: expected void *phyctl
>> drivers/phy/phy-sun4i-usb.c:178:39: got void [noderef] <asn:2>*
>> drivers/phy/phy-sun4i-usb.c:185:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:185:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:185:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:189:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:189:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:189:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:196:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:196:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:196:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:199:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:199:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:199:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:205:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:205:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:205:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:208:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:208:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:208:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:210:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:210:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:210:17: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:212:24: warning: incorrect type in argument 1
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:212:24: expected void const volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:212:24: got void *phyctl
>> drivers/phy/phy-sun4i-usb.c:214:17: warning: incorrect type in argument 2
>> (different address spaces)
>> drivers/phy/phy-sun4i-usb.c:214:17: expected void volatile [noderef]
>> <asn:2>*addr
>> drivers/phy/phy-sun4i-usb.c:214:17: got void *phyctl
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> Thanks for catching this:
>
> Acked-by: Hans de Goede <hdegoede@redhat.com>
applied, thanks.
-Kishon
>
> Regards,
>
> Hans
>
>
>> ---
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
>> Cc: Chen-Yu Tsai <wens@csie.org>
>> Cc: Hans de Goede <hdegoede@redhat.com>
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>> drivers/phy/phy-sun4i-usb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/phy/phy-sun4i-usb.c b/drivers/phy/phy-sun4i-usb.c
>> index bae54f7..9de9991 100644
>> --- a/drivers/phy/phy-sun4i-usb.c
>> +++ b/drivers/phy/phy-sun4i-usb.c
>> @@ -175,7 +175,7 @@ static void sun4i_usb_phy_write(struct sun4i_usb_phy
>> *phy, u32 addr, u32 data,
>> {
>> struct sun4i_usb_phy_data *phy_data = to_sun4i_usb_phy_data(phy);
>> u32 temp, usbc_bit = BIT(phy->index * 2);
>> - void *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
>> + void __iomem *phyctl = phy_data->base + phy_data->cfg->phyctl_offset;
>> int i;
>>
>> mutex_lock(&phy_data->mutex);
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-17 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 17:14 [PATCH] phy-sun4i-usb: fix missing __iomem * Ben Dooks
2016-06-08 10:09 ` Hans de Goede
2016-06-17 13:25 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).