From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: nomadik: fix warnings from unexported functions
Date: Tue, 7 Jun 2016 18:25:02 +0100 [thread overview]
Message-ID: <1465320302-5770-1-git-send-email-ben.dooks@codethink.co.uk> (raw)
There are five functions in the driver that are defined but
only used locally. Make these static to avoid the following
warnings:
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1036:6: warning: symbol 'nmk_gpio_clocks_enable' was not declared. Should it be static?
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1050:6: warning: symbol 'nmk_gpio_clocks_disable' was not declared. Should it be static?
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1073:6: warning: symbol 'nmk_gpio_wakeups_suspend' was not declared. Should it be static?
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1094:6: warning: symbol 'nmk_gpio_wakeups_resume' was not declared. Should it be static?
drivers/pinctrl/nomadik/pinctrl-nomadik.c:1120:6: warning: symbol 'nmk_gpio_read_pull' was not declared. Should it be static?
Note, this now produces warnings that these functions
are defined but not used.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alessandro Rubini <rubini@unipv.it>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-gpio at vger.kernel.org
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 38facef..a7cce0f 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1033,7 +1033,7 @@ static inline void nmk_gpio_dbg_show_one(struct seq_file *s,
#define nmk_gpio_dbg_show NULL
#endif
-void nmk_gpio_clocks_enable(void)
+static void nmk_gpio_clocks_enable(void)
{
int i;
@@ -1047,7 +1047,7 @@ void nmk_gpio_clocks_enable(void)
}
}
-void nmk_gpio_clocks_disable(void)
+static void nmk_gpio_clocks_disable(void)
{
int i;
@@ -1070,7 +1070,7 @@ void nmk_gpio_clocks_disable(void)
* PM ops are not used since this needs to be done at the end, after all the
* other drivers are done with their suspend callbacks.
*/
-void nmk_gpio_wakeups_suspend(void)
+static void nmk_gpio_wakeups_suspend(void)
{
int i;
@@ -1091,7 +1091,7 @@ void nmk_gpio_wakeups_suspend(void)
}
}
-void nmk_gpio_wakeups_resume(void)
+static void nmk_gpio_wakeups_resume(void)
{
int i;
@@ -1117,7 +1117,7 @@ void nmk_gpio_wakeups_resume(void)
* Note: only pull up/down set via this driver can
* be detected due to HW limitations.
*/
-void nmk_gpio_read_pull(int gpio_bank, u32 *pull_up)
+statoc void nmk_gpio_read_pull(int gpio_bank, u32 *pull_up)
{
if (gpio_bank < NUM_BANKS) {
struct nmk_gpio_chip *chip = nmk_gpio_chips[gpio_bank];
--
2.8.1
next reply other threads:[~2016-06-07 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 17:25 Ben Dooks [this message]
2016-06-07 17:30 ` [PATCH] pinctrl: nomadik: fix warnings from unexported functions Ben Dooks
2016-06-08 9:15 ` [Linux-kernel] " Ben Dooks
2016-06-08 12:14 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2016-06-08 16:07 Ben Dooks
2016-06-13 6:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465320302-5770-1-git-send-email-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).