From: garlic.tseng@mediatek.com (Garlic Tseng)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.
Date: Wed, 8 Jun 2016 11:32:22 +0800 [thread overview]
Message-ID: <1465356742.18601.7.camel@mtksdaap41> (raw)
In-Reply-To: <20160607163112.GD7510@sirena.org.uk>
On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote:
> On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote:
>
> > + if (val < 0 || val > MT2701_I2S_NUM) {
> > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n",
> > + __func__, num, val);
> > + return -1;
>
> Real error codes please.
OK I'll fix it.
>
> > +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = {
> > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1,
> > + 1),
> > +};
>
> On/off controls should end in Switch.
Do you means that the name should end in Switch? Something like "Multi
ch asrc out3 Switch" (or maybe a shorter one)
I'll fix it (if I don't misunderstand the comment)
Thanks!
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-06-08 3:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 4:56 [alsa-devel] [PATCH v2 0/9] ASoC: Mediatek: Add support for MT2701 SOC Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 1/9] ASoC: mediatek: Refine mt8173 driver and change config option Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 2/9] ASoC: mediatek: implement mediatek common structure Garlic Tseng
2016-06-07 15:54 ` Mark Brown
2016-06-08 2:06 ` Garlic Tseng
2016-06-09 10:44 ` Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 3/9] ASoC: mediatek: let mt8173 use " Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 4/9] ASoC: mediatek: add documents for mt2701 Garlic Tseng
2016-06-29 19:16 ` Applied "ASoC: mediatek: add documents for mt2701" to the asoc tree Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701 Garlic Tseng
2016-06-07 16:15 ` Mark Brown
2016-06-08 1:44 ` Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation Garlic Tseng
2016-06-07 16:31 ` Mark Brown
2016-06-08 3:32 ` Garlic Tseng [this message]
2016-06-09 10:44 ` Mark Brown
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 7/9] ASoC: bt-sco: extend rate and add a general compatible string Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 8/9] ASoC: mediatek: add BT implementation Garlic Tseng
2016-06-03 4:56 ` [alsa-devel] [PATCH v2 9/9] ASoC: mediatek: Add mt2701-cs42448 driver and config option Garlic Tseng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465356742.18601.7.camel@mtksdaap41 \
--to=garlic.tseng@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).